[GitHub] [incubator-shardingsphere] jiangxiewei edited a comment on issue #4464: when did the configuration **default-database-strategy** work ?

[GitBox <gi...@apache.org>]

jiangxiewei edited a comment on issue #4464: when did the configuration **default-database-strategy** work ?
URL: https://github.com/apache/incubator-shardingsphere/issues/4464#issuecomment-590751301
 
 
   in 3.1.0 , 
   when I use hintManager.setDatabaseShardingValue() , ShardingRouterFactory  will create DatabaseHintSQLRouter(deleted in 4.0.0)  as follow:
   ```java
       public static ShardingRouter newInstance(final ShardingRule shardingRule, final ShardingMetaData shardingMetaData, final DatabaseType databaseType, final boolean showSQL) {
           return HintManagerHolder.isDatabaseShardingOnly() ? new DatabaseHintSQLRouter(shardingRule, showSQL) : new ParsingSQLRouter(shardingRule, shardingMetaData, databaseType, showSQL);
       }
   ```
   
   so I rollback to 3.1.0 and the default-database-strategy work well .  
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services