RE: svn commit: r1412225 - in /subversion/trunk/subversion: include/svn_diff.h libsvn_client/diff.c libsvn_diff/util.c svnlook/main.c

[Bert Huijben <be...@qqmail.nl>]

> -----Original Message-----
> From: julianfoad@apache.org [mailto:julianfoad@apache.org]
> Sent: woensdag 21 november 2012 19:28
> To: commits@subversion.apache.org
> Subject: svn commit: r1412225 - in /subversion/trunk/subversion:
> include/svn_diff.h libsvn_client/diff.c libsvn_diff/util.c svnlook/main.c
> 
> Author: julianfoad
> Date: Wed Nov 21 18:27:35 2012
> New Revision: 1412225
> 
> URL: http://svn.apache.org/viewvc?rev=1412225&view=rev
> Log:
> Factor out the display of property diffs from 'svn' and 'svnlook'.  No
> functional change.
> 
> * subversion/include/svn_diff.h
>   (svn_diff_mem_string_output_unified2): Clarify how the header
> parameters
>     are used.
>   (svn_diff__display_prop_diffs): New function.

You should probably create a new subversion/include/privste/svn_diff_private.h header instead of adding private functions in public files.

But maybe you want to turn it into a public api before 1.8?

If it becomes public it needs, @since, etc.

	Bert 

Re: svn commit: r1412225 - in /subversion/trunk/subversion: include/svn_diff.h libsvn_client/diff.c libsvn_diff/util.c svnlook/main.c

[Julian Foad <ju...@btopenworld.com>]

Bert Huijben wrote:

>>  Author: julianfoad
>> 
>>  URL: http://svn.apache.org/viewvc?rev=1412225&view=rev
>>  Log:
>>  Factor out the display of property diffs from 'svn' and 
>> 'svnlook'.  No  functional change.
>> 
>>  * subversion/include/svn_diff.h
>>    (svn_diff_mem_string_output_unified2): Clarify how the header
>>  parameters  are used.
>>    (svn_diff__display_prop_diffs): New function.
> 
> You should probably create a new subversion/include/privste/svn_diff_private.h 
> header instead of adding private functions in public files.

You're right -- I will.

> But maybe you want to turn it into a public api before 1.8?

I initially thought it would be public, but then I found it has some problems (with encoding, and with "No newline at end of property") so I don't want to make it public yet.

> If it becomes public it needs, @since, etc.

Of course.

Thanks for the review.

- Julian