[GitHub] [superset] villebro commented on a change in pull request #13578: fix: better handle datasource exceptions

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #13578:
URL: https://github.com/apache/superset/pull/13578#discussion_r594212362



##########
File path: superset/databases/commands/update.py
##########
@@ -54,7 +54,7 @@ def run(self) -> Model:
             # TODO Improve this simplistic implementation for catching DB conn fails
             try:
                 schemas = database.get_all_schema_names()
-            except Exception:
+            except Exception as ex:

Review comment:
       Should we wrap `ex` in the `DatabaseConnectionFailedError`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org