You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Hans Bakker (JIRA)" <ji...@apache.org> on 2006/06/01 08:45:29 UTC

[jira] Created: (OFBIZ-12) using the maindecorator from web.xml in webtools

using the maindecorator from web.xml in webtools
------------------------------------------------

         Key: OFBIZ-12
         URL: http://issues.apache.org/jira/browse/OFBIZ-12
     Project: The Open For Business Project
        Type: Improvement

  Components: framework  
    Reporter: Hans Bakker




-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (OFBIZ-12) using the maindecorator from web.xml in webtools

Posted by "Hans Bakker (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/OFBIZ-12?page=all ]

Hans Bakker reassigned OFBIZ-12:
--------------------------------

    Assign To: David E. Jones

> using the maindecorator from web.xml in webtools
> ------------------------------------------------
>
>          Key: OFBIZ-12
>          URL: http://issues.apache.org/jira/browse/OFBIZ-12
>      Project: The Open For Business Project
>         Type: Improvement

>   Components: framework
>     Reporter: Hans Bakker
>     Assignee: David E. Jones
>  Attachments: webtools20060601.patch
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (OFBIZ-12) using the maindecorator from web.xml in webtools

Posted by "Hans Bakker (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/OFBIZ-12?page=all ]

Hans Bakker updated OFBIZ-12:
-----------------------------

    Attachment: webtools20060601.patch

> using the maindecorator from web.xml in webtools
> ------------------------------------------------
>
>          Key: OFBIZ-12
>          URL: http://issues.apache.org/jira/browse/OFBIZ-12
>      Project: The Open For Business Project
>         Type: Improvement

>   Components: framework
>     Reporter: Hans Bakker
>  Attachments: webtools20060601.patch
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (OFBIZ-12) using the maindecorator from web.xml in webtools

Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/OFBIZ-12?page=all ]
     
David E. Jones closed OFBIZ-12:
-------------------------------

    Fix Version: SVN trunk
     Resolution: Fixed

Thanks for working on this Hans. I have a couple points of feedback, but in general it looks fine and the changes are in SVN rev 7747.

Now the fun feedback part...

In the AvailableServicesScreens.xml file there's no need to change the indentation on the header, so I left that out. Also, for the XML ASL2 headers they shouldn't be indented. My guess is your editor does this automatically, so while it's not a big deal you might want to keep an eye out for this.

Another thing to keep in mind for the ASL2 headers is to watch the opening copyright date. I don't know if it's a big deal, but a lot of the existing files have an opening date that is _hopefully_ correct, and that should be used in the ASL2 header instead of 2001.

Thanks again. This is a step forward for the webtools webapp, but of course the old problem still remains where most of the pages there are still using JSP and can't take advantage of this sort of flexibility.

> using the maindecorator from web.xml in webtools
> ------------------------------------------------
>
>          Key: OFBIZ-12
>          URL: http://issues.apache.org/jira/browse/OFBIZ-12
>      Project: The Open For Business Project
>         Type: Improvement

>   Components: framework
>     Reporter: Hans Bakker
>     Assignee: David E. Jones
>      Fix For: SVN trunk
>  Attachments: webtools20060601.patch
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira