You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/26 08:47:57 UTC
[GitHub] [incubator-nuttx] btashton opened a new pull request #2404: Update checkrelease script for readme.md inread of .txt
btashton opened a new pull request #2404:
URL: https://github.com/apache/incubator-nuttx/pull/2404
## Summary
When the readme was converted to markdown the extension to look for in in the release verification script was not updated and would fail like this:
```
Checking apache-nuttx-10.0.0-incubating.tar.gz for required files:
- README.txt file not present.
```
This corrects the filename.
## Impact
The release checking script now passes.
## Testing
Here it is running against the latest staged RC
```
❯ ./tools/checkrelease.sh --release 10.0.0-RC0
<<TRIM>>
Checking apache-nuttx-10.0.0-incubating.tar.gz sha512...
OK: apache-nuttx-10.0.0-incubating.tar.gz sha512 hash matches.
Checking apache-nuttx-10.0.0-incubating.tar.gz GPG signature:
<<TRIM>>
Primary key fingerprint: 3554 D784 58CE B695 4B02 0E12 E1B6 E30D B05D 6280
Subkey fingerprint: 66C4 832A 165E CC93 5489 5A20 9750 ED7E 692B 99E2
OK: apache-nuttx-10.0.0-incubating.tar.gz gpg signature matches.
Checking apache-nuttx-10.0.0-incubating.tar.gz for required files:
OK: all required files exist in nuttx.
Checking apache-nuttx-apps-10.0.0-incubating.tar.gz sha512...
OK: apache-nuttx-apps-10.0.0-incubating.tar.gz sha512 hash matches.
Checking apache-nuttx-apps-10.0.0-incubating.tar.gz GPG signature:
<<TRIM>>
OK: apache-nuttx-apps-10.0.0-incubating.tar.gz gpg signature matches.
Checking apache-nuttx-apps-10.0.0-incubating.tar.gz for required files:
OK: all required files exist in apps.
Trying to build nuttx sim:nsh...
OK: we were able to build sim:nsh.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2404: Update checkrelease script to check readme.md instead of .txt
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2404:
URL: https://github.com/apache/incubator-nuttx/pull/2404#issuecomment-734357813
> Do you plan to backport this one? I don't think we should cancel the current RC for a change in tools/.
I was not planning on it, if we do a RC1 we can backport it in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2404: Update checkrelease script to check readme.md instead of .txt
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2404:
URL: https://github.com/apache/incubator-nuttx/pull/2404
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2404: Update checkrelease script to check readme.md instead of .txt
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #2404:
URL: https://github.com/apache/incubator-nuttx/pull/2404#issuecomment-734201326
Do you plan to backport this one? I don't think we should cancel the current RC for a change in tools/.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org