You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "wypoon (via GitHub)" <gi...@apache.org> on 2023/09/21 22:04:12 UTC
[GitHub] [iceberg] wypoon opened a new pull request, #8617: Core: Use avro compression properties from table properties when writing manifests and manifest lists (API change)
wypoon opened a new pull request, #8617:
URL: https://github.com/apache/iceberg/pull/8617
Variant of https://github.com/apache/iceberg/pull/6799 except that new `newAppender` method added to `ManifestWriter` is declared abstract.
This means that it is a breaking API change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Use avro compression properties from table properties when writing manifests and manifest lists (API change) [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #8617: Core: Use avro compression properties from table properties when writing manifests and manifest lists (API change)
URL: https://github.com/apache/iceberg/pull/8617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] wypoon commented on pull request #8617: Core: Use avro compression properties from table properties when writing manifests and manifest lists (API change)
Posted by "wypoon (via GitHub)" <gi...@apache.org>.
wypoon commented on PR #8617:
URL: https://github.com/apache/iceberg/pull/8617#issuecomment-1730360909
@nastra @ConeyLiu this is the same as the latest in https://github.com/apache/iceberg/pull/6799 plus one more commit, to make the new `newAppender` method in `ManifestWriter` abstract.
We can break the API now or later. It might be better to break it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Use avro compression properties from table properties when writing manifests and manifest lists (API change) [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8617:
URL: https://github.com/apache/iceberg/pull/8617#issuecomment-2378157592
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Use avro compression properties from table properties when writing manifests and manifest lists (API change) [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8617:
URL: https://github.com/apache/iceberg/pull/8617#issuecomment-2362461302
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] wypoon commented on a diff in pull request #8617: Core: Use avro compression properties from table properties when writing manifests and manifest lists (API change)
Posted by "wypoon (via GitHub)" <gi...@apache.org>.
wypoon commented on code in PR #8617:
URL: https://github.com/apache/iceberg/pull/8617#discussion_r1334567304
##########
.palantir/revapi.yml:
##########
@@ -833,6 +829,13 @@ acceptedBreaks:
- code: "java.class.removed"
old: "interface org.apache.iceberg.actions.RewritePositionDeleteStrategy"
justification: "Removing deprecated code"
+ - code: "java.method.abstractMethodAdded"
Review Comment:
Yes, your suggestion was followed in https://github.com/apache/iceberg/pull/6799 and I haven't reverted it there.
I think @ConeyLiu's point is that the new `newAppender` method doesn't break the API because it is not abstract -- it calls the old `newAppender`. However, the old `newAppender` is deprecated and when it is removed, the new `newAppender` then has to be changed. There is no natural implementation for it, so it should be abstract. Of course, one could do something else, such as return null or throw an `UnsupportedOperationException`.
If anyone out there actually writes their own `ManifestWriter` subclass, they would need to implement a `newAppender(PartitionSpec, OutputFile, String, Integer)` method. We avoid breaking the API now, which allows them to get way without implementing the new method, but when `newAppender(PartitionSpec, OutputFile)` is then removed, that will break them (even if we do not technically break the API by keeping `newAppender(PartitionSpec, OutputFile, String, Integer)` non-abstract and throwing an `UnsupportedOperationException` -- it effectively breaks them).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a diff in pull request #8617: Core: Use avro compression properties from table properties when writing manifests and manifest lists (API change)
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #8617:
URL: https://github.com/apache/iceberg/pull/8617#discussion_r1333857399
##########
.palantir/revapi.yml:
##########
@@ -833,6 +829,13 @@ acceptedBreaks:
- code: "java.class.removed"
old: "interface org.apache.iceberg.actions.RewritePositionDeleteStrategy"
justification: "Removing deprecated code"
+ - code: "java.method.abstractMethodAdded"
Review Comment:
we shouldn't be breaking the API. See also my comment in https://github.com/apache/iceberg/pull/6799#discussion_r1108121835 on how to avoid breaking the API for adding the new method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] wypoon commented on a diff in pull request #8617: Core: Use avro compression properties from table properties when writing manifests and manifest lists (API change)
Posted by "wypoon (via GitHub)" <gi...@apache.org>.
wypoon commented on code in PR #8617:
URL: https://github.com/apache/iceberg/pull/8617#discussion_r1334567304
##########
.palantir/revapi.yml:
##########
@@ -833,6 +829,13 @@ acceptedBreaks:
- code: "java.class.removed"
old: "interface org.apache.iceberg.actions.RewritePositionDeleteStrategy"
justification: "Removing deprecated code"
+ - code: "java.method.abstractMethodAdded"
Review Comment:
Yes, your suggestion was followed in https://github.com/apache/iceberg/pull/6799 and I haven't reverted it there.
I think @ConeyLiu's point is that the new `newAppender` method doesn't break the API because it is not abstract -- it calls the old `newAppender`. However, the old `newAppender` is deprecated and when it is removed, the new `newAppender` then has to be changed. There is no natural implementation for it, so it should be abstract. Of course, one could do something else, such as return null or throw an `UnsupportedOperationException`.
If anyone out there actually writes their own `ManifestWriter` subclass, they would need to implement a `newAppender(PartitionSpec, OutputFile, String, Integer)` method. We avoid breaking the API now, which allows them to get away without implementing the new method, but when `newAppender(PartitionSpec, OutputFile)` is then removed, that will break them (even if we do not technically break the API by keeping `newAppender(PartitionSpec, OutputFile, String, Integer)` non-abstract and throwing an `UnsupportedOperationException` -- it effectively breaks them).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org