You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Munendra S N (Jira)" <ji...@apache.org> on 2020/03/12 02:24:00 UTC
[jira] [Comment Edited] (SOLR-13944) CollapsingQParserPlugin throws
NPE instead of bad request
[ https://issues.apache.org/jira/browse/SOLR-13944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17057528#comment-17057528 ]
Munendra S N edited comment on SOLR-13944 at 3/12/20, 2:23 AM:
---------------------------------------------------------------
[~tflobbe]
Just {{QParser.getParser}} won't work in {{\{!tag=collapser\}\{!collapse field=productId sort='merchantOrder asc, price asc, id asc'\}}} as it return default parser and on calling getQuery localParams are parsed
[~jbernste]
Thanks for the ping, I reran tests without Collator and they pass after SOLR-14073. So, my current idea is to keep the additional tests and simplify collator logic(not to bother about collapse string match)
[^SOLR-13944.patch]
was (Author: munendrasn):
[~tflobbe]
Just {{QParser.getParser}} won't work in {{\{!tag=collapser\}\{!collapse field=productId sort='merchantOrder asc, price asc, id asc'\}}} So, we needed to parsing
[~jbernste]
Thanks for the ping, I reran tests without Collator and they pass after SOLR-14073. So, my current idea is to keep the additional tests and simplify collator logic(not to bother about collapse string match)
[^SOLR-13944.patch]
> CollapsingQParserPlugin throws NPE instead of bad request
> ---------------------------------------------------------
>
> Key: SOLR-13944
> URL: https://issues.apache.org/jira/browse/SOLR-13944
> Project: Solr
> Issue Type: Bug
> Affects Versions: 7.3.1
> Reporter: Stefan
> Assignee: Munendra S N
> Priority: Minor
> Attachments: SOLR-13944.patch, SOLR-13944.patch, SOLR-13944.patch
>
>
> I noticed the following NPE:
> {code:java}
> java.lang.NullPointerException at org.apache.solr.search.CollapsingQParserPlugin$OrdFieldValueCollector.finish(CollapsingQParserPlugin.java:1021) at org.apache.solr.search.CollapsingQParserPlugin$OrdFieldValueCollector.finish(CollapsingQParserPlugin.java:1081) at org.apache.solr.search.SolrIndexSearcher.buildAndRunCollectorChain(SolrIndexSearcher.java:230) at org.apache.solr.search.SolrIndexSearcher.getDocListNC(SolrIndexSearcher.java:1602) at org.apache.solr.search.SolrIndexSearcher.getDocListC(SolrIndexSearcher.java:1419) at org.apache.solr.search.SolrIndexSearcher.search(SolrIndexSearcher.java:584)
> {code}
> If I am correct, the problem was already addressed in SOLR-8807. The fix does was not working in this case though, because of a syntax error in the query (I used the local parameter syntax twice instead of combining it). The relevant part of the query is:
> {code:java}
> &fq={!tag=collapser}{!collapse field=productId sort='merchantOrder asc, price asc, id asc'}
> {code}
> After discussing that on the mailing list, I was asked to open a ticket, because this situation should result in a bad request instead of a NullpointerException (see [https://mail-archives.apache.org/mod_mbox/lucene-solr-user/201911.mbox/%3CCAMJgJxTuSb%3D8szO8bvHiAafJOs08O_NMB4pcaHOXME4Jj-GO2A%40mail.gmail.com%3E])
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org