[jira] [Comment Edited] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

["Jonathan Hsieh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647060#comment-13647060 ] 

Jonathan Hsieh edited comment on HBASE-8465 at 5/1/13 11:20 PM:
----------------------------------------------------------------

bq. I tought you were against this one... and I guess Ted read it in my same way

[~mbertozzi] We want to have all the mechanisms for any combination.  At this point I want it to act like whatever is most similar to popular existing database's snapshot features.  I don't know what this means at the moment, but from talking with [~esammer], the option of not having an auto-failsafe-snapshot is a good one.


                
      was (Author: jmhsieh):
    bq. I tought you were against this one... and I guess Ted read it in my same way

[~mbertozzi] We have all the mechanisms for any combination.  At this point I want it to act like whatever is most similar to popular existing database's snapshot features.  I don't know what this means at the moment, but from talking with [~esammer], the option of not having an auto-failsafe-snapshot is a good one.


                  
> Auto-drop rollback snapshot for snapshot restore
> ------------------------------------------------
>
>                 Key: HBASE-8465
>                 URL: https://issues.apache.org/jira/browse/HBASE-8465
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.98.0, 0.95.1
>
>         Attachments: 8465-trunk-v1.txt, 8465-trunk-v2.txt
>
>
> Below is an excerpt from snapshot restore javadoc:
> {code}
>    * Restore the specified snapshot on the original table. (The table must be disabled)
>    * Before restoring the table, a new snapshot with the current table state is created.
>    * In case of failure, the table will be rolled back to the its original state.
> {code}
> We can improve the handling of rollbackSnapshot in two ways:
> 1. give better name to the rollbackSnapshot (adding {code}'-for-rollback-'{code}). Currently the name is of the form:
>     String rollbackSnapshot = snapshotName + "-" + EnvironmentEdgeManager.currentTimeMillis();
> 2. drop rollbackSnapshot at the end of restoreSnapshot() if the restore is successful. We can introduce new config param, named 'hbase.snapshot.restore.drop.rollback', to keep compatibility with current behavior.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira