[GitHub] [flink] MartijnVisser commented on a diff in pull request #21339: [FLINK-30024][tests] Build local test KDC docker image

[GitBox <gi...@apache.org>]

MartijnVisser commented on code in PR #21339:
URL: https://github.com/apache/flink/pull/21339#discussion_r1025282921


##########
flink-end-to-end-tests/test-scripts/common_yarn_docker.sh:
##########
@@ -100,13 +100,10 @@ function build_image() {
     echo "Pre-downloading Hadoop tarball"
     local cache_path
     cache_path=$(get_artifact "http://archive.apache.org/dist/hadoop/common/hadoop-2.8.5/hadoop-2.8.5.tar.gz")
-    ln "${cache_path}" "${END_TO_END_DIR}/test-scripts/docker-hadoop-secure-cluster/hadoop-2.8.5.tar.gz"
+    ln "${cache_path}" "${END_TO_END_DIR}/test-scripts/docker-hadoop-secure-cluster/hadoop/hadoop.tar.gz"

Review Comment:
   IIRC the danger of this is that now any Hadoop version will get cached, because there's no version number anymore. That means that if an upgrade is done from Hadoop 2.8.5 to 2.10.2, no new Hadoop TAR will be downloaded because it will be cached from a previous run. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org