[GitHub] [spark] Daniel-Davies edited a comment on pull request #35032: [SPARK-37738][PYTHON] Support column type inputs for second arg of date manipulation functions

[GitBox <gi...@apache.org>]

Daniel-Davies edited a comment on pull request #35032:
URL: https://github.com/apache/spark/pull/35032#issuecomment-1003051764


   Yes, the ones I saw were:
   
   - F.when: Completely agree, I think we should leave this one alone
   - F.overlay: Annotation only
   - F.least: Annotation only
   - F.slice: Needs a conversion
   - F.array_repeat: Needs a conversion
   - F.percentile_approx: I don't think this should take a column name either way though
   
   So really there are only two annotation changes & two column conversions needed from what I can see. Happy to update these, or if you don't think they're worth pursuing/ have reasons for being this way, we may want to leave them alone.
   
   I've added a ticket so that we can refer back to it if anyone asks in future: https://issues.apache.org/jira/browse/SPARK-37788


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org