You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2022/02/18 10:34:00 UTC
[GitHub] [httpcomponents-client] cda007 opened a new pull request #351: Update HttpAsyncClientBuilder.java
cda007 opened a new pull request #351:
URL: https://github.com/apache/httpcomponents-client/pull/351
Add the option to set an IOSessionListener on HttpAsyncClientBuilder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] cda007 commented on pull request #351: Async HttpClient builders to support custom IOSessionListener
Posted by GitBox <gi...@apache.org>.
cda007 commented on pull request #351:
URL: https://github.com/apache/httpcomponents-client/pull/351#issuecomment-1044914487
Hi Oleg,
Sorry for this. As I told you I am not familiar with this process and with git. Is there any specific pre-commit hook that would avoid to commit code not respecting rules ?
Regards,
Christophe
> On 18 Feb 2022, at 18:21, Oleg Kalnichevski ***@***.***> wrote:
>
>
> @cda007 <https://github.com/cda007> The build still fails. There are still trailing blanks left.
>
> —
> Reply to this email directly, view it on GitHub <https://github.com/apache/httpcomponents-client/pull/351#issuecomment-1044872336>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIQJ5BYPBGP6P73SUL3L4NDU3Z52JANCNFSM5OXPCTSA>.
> Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
> You are receiving this because you were mentioned.
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #351: Async HttpClient builders to support custom IOSessionListener
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #351:
URL: https://github.com/apache/httpcomponents-client/pull/351#issuecomment-1044872336
@cda007 The build still fails. There are still trailing blanks left.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on a change in pull request #351: Update HttpAsyncClientBuilder.java
Posted by GitBox <gi...@apache.org>.
ok2c commented on a change in pull request #351:
URL: https://github.com/apache/httpcomponents-client/pull/351#discussion_r809921984
##########
File path: httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/HttpAsyncClientBuilder.java
##########
@@ -318,7 +320,15 @@ public final HttpAsyncClientBuilder setIOReactorConfig(final IOReactorConfig ioR
this.ioReactorConfig = ioReactorConfig;
return this;
}
-
Review comment:
@cda007 Could you please add `@since 5.2` tag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c merged pull request #351: Async HttpClient builders to support custom IOSessionListener
Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #351:
URL: https://github.com/apache/httpcomponents-client/pull/351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] cda007 commented on pull request #351: Async HttpClient builders to support custom IOSessionListener
Posted by GitBox <gi...@apache.org>.
cda007 commented on pull request #351:
URL: https://github.com/apache/httpcomponents-client/pull/351#issuecomment-1046720900
Fixed. I use now to maven verification tool, should not occur anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] cda007 commented on a change in pull request #351: Async HttpClient builders to support custom IOSessionListener
Posted by GitBox <gi...@apache.org>.
cda007 commented on a change in pull request #351:
URL: https://github.com/apache/httpcomponents-client/pull/351#discussion_r810097731
##########
File path: httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/HttpAsyncClientBuilder.java
##########
@@ -318,7 +320,15 @@ public final HttpAsyncClientBuilder setIOReactorConfig(final IOReactorConfig ioR
this.ioReactorConfig = ioReactorConfig;
return this;
}
-
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #351: Async HttpClient builders to support custom IOSessionListener
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #351:
URL: https://github.com/apache/httpcomponents-client/pull/351#issuecomment-1044945590
@cda007 This has nothing to do with git. This is straight Maven. `mvn clean verify` has got to pass for you locally with your changes. Style rules like no trailing blanks are enforced by the Maven style-check plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] michael-o commented on a change in pull request #351: Async HttpClient builders to support custom IOSessionListener
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #351:
URL: https://github.com/apache/httpcomponents-client/pull/351#discussion_r810665877
##########
File path: httpclient5/src/main/java/org/apache/hc/client5/http/CircularRedirectException.java
##########
@@ -39,7 +39,7 @@
* Creates a new CircularRedirectException with a {@code null} detail message.
*/
public CircularRedirectException() {
- super();
+ super();
Review comment:
Redundant space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] SmallerCoder commented on pull request #351: Update HttpAsyncClientBuilder.java
Posted by GitBox <gi...@apache.org>.
SmallerCoder commented on pull request #351:
URL: https://github.com/apache/httpcomponents-client/pull/351#issuecomment-1044298742
邮件已收到！我会尽快阅读！谢谢！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #351: Async HttpClient builders to support custom IOSessionListener
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #351:
URL: https://github.com/apache/httpcomponents-client/pull/351#issuecomment-1044786007
@cda007 Looks good to me. Please fix the check-style violations (trailing blanks) and I will merge your changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org