You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Chris Chabot (JIRA)" <ji...@apache.org> on 2008/08/26 18:06:46 UTC
[jira] Created: (SHINDIG-541) Tiered message bundles
Tiered message bundles
-----------------------
Key: SHINDIG-541
URL: https://issues.apache.org/jira/browse/SHINDIG-541
Project: Shindig
Issue Type: Bug
Reporter: Chris Chabot
Priority: Critical
Currently shindig uses only one localization pack (whichever language pack matches the preffered language the closest), and uses only that for message tag substitution.
However the correct behavior should be that if a translation tag (__MSG_foo) is not found in the active language set, it should try the the next best match (so first en-US, then en-ALL, then ALL-ALL if the previous 2 failed) and use that for translation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-541) Tiered message bundles
Posted by "impetus technologies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
impetus technologies updated SHINDIG-541:
-----------------------------------------
Attachment: MessageBundleParser.php.patch
GadgetServer.php.patch
Hi,
I have created patches for the same. Please verify them.
I have also used some dummy xml files for testing. Please let me know if needs to add them also.
Thanks
Ruchi Kothari
> Tiered message bundles
> -----------------------
>
> Key: SHINDIG-541
> URL: https://issues.apache.org/jira/browse/SHINDIG-541
> Project: Shindig
> Issue Type: Bug
> Reporter: Chris Chabot
> Priority: Critical
> Attachments: GadgetServer.php.patch, MessageBundleParser.php.patch
>
>
> Currently shindig uses only one localization pack (whichever language pack matches the preffered language the closest), and uses only that for message tag substitution.
> However the correct behavior should be that if a translation tag (__MSG_foo) is not found in the active language set, it should try the the next best match (so first en-US, then en-ALL, then ALL-ALL if the previous 2 failed) and use that for translation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-541) Tiered message bundles
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Chabot updated SHINDIG-541:
---------------------------------
Component/s: Gadget Rendering Server (PHP)
> Tiered message bundles
> -----------------------
>
> Key: SHINDIG-541
> URL: https://issues.apache.org/jira/browse/SHINDIG-541
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Chris Chabot
> Priority: Critical
> Attachments: GadgetServer.php.patch, MessageBundleParser.php.patch
>
>
> Currently shindig uses only one localization pack (whichever language pack matches the preffered language the closest), and uses only that for message tag substitution.
> However the correct behavior should be that if a translation tag (__MSG_foo) is not found in the active language set, it should try the the next best match (so first en-US, then en-ALL, then ALL-ALL if the previous 2 failed) and use that for translation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-541) Tiered message bundles
Posted by "Pan Jie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652249#action_12652249 ]
Pan Jie commented on SHINDIG-541:
---------------------------------
Hi, there is an error in impetus's patch. There is a failure case for his patch. Suppose lang = en and country = US, when message "test" exist in en_ALL.xml but doesn't exist in en_US.xml and ALL_ALL.xml, gadgets couldn't retrieve message "test".
I have made a patch to fix this issue. Here are changes to impetus's patch:
1. Fixed an error when implementing message fallback.
2. Used multiFetch instead of single fetch.
3. Fixed a failed unittest.
> Tiered message bundles
> -----------------------
>
> Key: SHINDIG-541
> URL: https://issues.apache.org/jira/browse/SHINDIG-541
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Chris Chabot
> Priority: Critical
> Attachments: 20081201.patch, GadgetServer.php.patch, MessageBundleParser.php.patch
>
>
> Currently shindig uses only one localization pack (whichever language pack matches the preffered language the closest), and uses only that for message tag substitution.
> However the correct behavior should be that if a translation tag (__MSG_foo) is not found in the active language set, it should try the the next best match (so first en-US, then en-ALL, then ALL-ALL if the previous 2 failed) and use that for translation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-541) Tiered message bundles
Posted by "Pan Jie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652250#action_12652250 ]
Pan Jie commented on SHINDIG-541:
---------------------------------
Here is an example gadget: http://hosting.gmodules.com/ig/gadgets/file/108293471617599476830/debug-messagebundle-10.xml
> Tiered message bundles
> -----------------------
>
> Key: SHINDIG-541
> URL: https://issues.apache.org/jira/browse/SHINDIG-541
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Chris Chabot
> Priority: Critical
> Attachments: 20081201.patch, GadgetServer.php.patch, MessageBundleParser.php.patch
>
>
> Currently shindig uses only one localization pack (whichever language pack matches the preffered language the closest), and uses only that for message tag substitution.
> However the correct behavior should be that if a translation tag (__MSG_foo) is not found in the active language set, it should try the the next best match (so first en-US, then en-ALL, then ALL-ALL if the previous 2 failed) and use that for translation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-541) Tiered message bundles
Posted by "Pan Jie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pan Jie updated SHINDIG-541:
----------------------------
Attachment: 20081201.patch
> Tiered message bundles
> -----------------------
>
> Key: SHINDIG-541
> URL: https://issues.apache.org/jira/browse/SHINDIG-541
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Chris Chabot
> Priority: Critical
> Attachments: 20081201.patch, GadgetServer.php.patch, MessageBundleParser.php.patch
>
>
> Currently shindig uses only one localization pack (whichever language pack matches the preffered language the closest), and uses only that for message tag substitution.
> However the correct behavior should be that if a translation tag (__MSG_foo) is not found in the active language set, it should try the the next best match (so first en-US, then en-ALL, then ALL-ALL if the previous 2 failed) and use that for translation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-541) Tiered message bundles
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648973#action_12648973 ]
Chris Chabot commented on SHINDIG-541:
--------------------------------------
please please please always file php-shindig patches under one of the *-PHP components otherwise there's an incredibly large chance that I'll never see the jira entry!
> Tiered message bundles
> -----------------------
>
> Key: SHINDIG-541
> URL: https://issues.apache.org/jira/browse/SHINDIG-541
> Project: Shindig
> Issue Type: Bug
> Reporter: Chris Chabot
> Priority: Critical
> Attachments: GadgetServer.php.patch, MessageBundleParser.php.patch
>
>
> Currently shindig uses only one localization pack (whichever language pack matches the preffered language the closest), and uses only that for message tag substitution.
> However the correct behavior should be that if a translation tag (__MSG_foo) is not found in the active language set, it should try the the next best match (so first en-US, then en-ALL, then ALL-ALL if the previous 2 failed) and use that for translation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-541) Tiered message bundles
Posted by "impetus technologies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651489#action_12651489 ]
impetus technologies commented on SHINDIG-541:
----------------------------------------------
Hi Chris,
I have tried to follow you suggestions but after all investigation on how it works I could not actually think of the solution with mutifetcher. The reason behind this is message bundle is loaded with the users preference. right? and that is replaced with the placeholders and also bundled with the response gadget (please let me know if I am wrong). So why we want to retrieve all the message bundles at the same time ? May be I am not aware of what all is happening in the gadget rendering part, so please give me some pointers if I am lacking somewhere.
> Tiered message bundles
> -----------------------
>
> Key: SHINDIG-541
> URL: https://issues.apache.org/jira/browse/SHINDIG-541
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Chris Chabot
> Priority: Critical
> Attachments: GadgetServer.php.patch, MessageBundleParser.php.patch
>
>
> Currently shindig uses only one localization pack (whichever language pack matches the preffered language the closest), and uses only that for message tag substitution.
> However the correct behavior should be that if a translation tag (__MSG_foo) is not found in the active language set, it should try the the next best match (so first en-US, then en-ALL, then ALL-ALL if the previous 2 failed) and use that for translation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-541) Tiered message bundles
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Chabot closed SHINDIG-541.
--------------------------------
Resolution: Fixed
Assignee: Chris Chabot
Thanks for looking @ this Pan!
Patch LGTM and it's been committed.
> Tiered message bundles
> -----------------------
>
> Key: SHINDIG-541
> URL: https://issues.apache.org/jira/browse/SHINDIG-541
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Chris Chabot
> Assignee: Chris Chabot
> Priority: Critical
> Attachments: 20081201.patch, GadgetServer.php.patch, MessageBundleParser.php.patch
>
>
> Currently shindig uses only one localization pack (whichever language pack matches the preffered language the closest), and uses only that for message tag substitution.
> However the correct behavior should be that if a translation tag (__MSG_foo) is not found in the active language set, it should try the the next best match (so first en-US, then en-ALL, then ALL-ALL if the previous 2 failed) and use that for translation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SHINDIG-541) Tiered message bundles
Posted by "impetus technologies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632124#action_12632124 ]
impetus edited comment on SHINDIG-541 at 9/18/08 12:34 AM:
------------------------------------------------------------------------
Hi,
I have created patches for the same. Please verify them.
I have also used some dummy xml files for testing. Please let me know if needs to add them also.
Thanks
was (Author: impetus):
Hi,
I have created patches for the same. Please verify them.
I have also used some dummy xml files for testing. Please let me know if needs to add them also.
Thanks
Ruchi Kothari
> Tiered message bundles
> -----------------------
>
> Key: SHINDIG-541
> URL: https://issues.apache.org/jira/browse/SHINDIG-541
> Project: Shindig
> Issue Type: Bug
> Reporter: Chris Chabot
> Priority: Critical
> Attachments: GadgetServer.php.patch, MessageBundleParser.php.patch
>
>
> Currently shindig uses only one localization pack (whichever language pack matches the preffered language the closest), and uses only that for message tag substitution.
> However the correct behavior should be that if a translation tag (__MSG_foo) is not found in the active language set, it should try the the next best match (so first en-US, then en-ALL, then ALL-ALL if the previous 2 failed) and use that for translation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-541) Tiered message bundles
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648974#action_12648974 ]
Chris Chabot commented on SHINDIG-541:
--------------------------------------
Looking @ the patches I see that it's not using the multi_fetch feature that we've added to the remove content fetchers, specifically for this case :)
Fetching bundles one by one / sequentially is very slow and will make the initial render way to slow, that's why it's essential we fetch *all* message bundles simultaneously (using the multi fetch function) and then process them from there.
Could you possibly update the patch to reflect this? thanks!
> Tiered message bundles
> -----------------------
>
> Key: SHINDIG-541
> URL: https://issues.apache.org/jira/browse/SHINDIG-541
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Chris Chabot
> Priority: Critical
> Attachments: GadgetServer.php.patch, MessageBundleParser.php.patch
>
>
> Currently shindig uses only one localization pack (whichever language pack matches the preffered language the closest), and uses only that for message tag substitution.
> However the correct behavior should be that if a translation tag (__MSG_foo) is not found in the active language set, it should try the the next best match (so first en-US, then en-ALL, then ALL-ALL if the previous 2 failed) and use that for translation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.