You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/27 09:04:42 UTC

[GitHub] ashb commented on a change in pull request #4566: [AIRFLOW-3566] - Adding timeout and login_timeout to MsSqlHook

ashb commented on a change in pull request #4566: [AIRFLOW-3566] - Adding timeout and login_timeout to MsSqlHook
URL: https://github.com/apache/airflow/pull/4566#discussion_r251226584
 
 

 ##########
 File path: airflow/hooks/mssql_hook.py
 ##########
 @@ -45,7 +47,9 @@ def get_conn(self):
             user=conn.login,
             password=conn.password,
             database=self.schema or conn.schema,
-            port=conn.port)
+            port=conn.port,
+            timeout=self.timeout,
+            login_timeout=self.login_timeout or conn.login_timeout)
 
 Review comment:
   Conn.login_timeout isn't a property that exists is it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services