You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2019/12/09 14:55:13 UTC

[GitHub] [ignite] agura commented on a change in pull request #6696: IGNITE-11987: Metrics configuration.

agura commented on a change in pull request #6696: IGNITE-11987: Metrics configuration.
URL: https://github.com/apache/ignite/pull/6696#discussion_r355462202
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/metric/GridMetricManager.java
 ##########
 @@ -175,6 +185,12 @@
     /** */
     private static final Collection<GarbageCollectorMXBean> gc = ManagementFactory.getGarbageCollectorMXBeans();
 
+    /** Prefix for {@link HitRateMetric} configuration property name. */
+    public static final String HITRATE_CFG_PREFIX = metricName("metrics", "hitrate");
 
 Review comment:
   I believe that we shouldn't configure HitRate metrics at all because there is no valid cases for it. See corresponding discussion on dev-list. So only histograms should be configurable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services