You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/22 03:31:36 UTC
[GitHub] [rocketmq] BurningCN opened a new issue, #4194: Suggestions on how invokeAsyncImpl method handles responseFuture
BurningCN opened a new issue, #4194:
URL: https://github.com/apache/rocketmq/issues/4194
The `responseFuture` has a `timeoutMillis` attribute, and `NettyRemotingClient/Server#timer` will call `scheduleAtFixedRate->scanResponseTable`.
If the client initiates an asynchronous request, the response comes, and the callback(`ResponseFuture#invokeCallback`) of the asynchronous request is also triggered (everything is normal, no timeout). The current code lacks a proper place to perform the `responseTable.remove(responseFuture.getOpaque());` operation instead of waiting for the `timer` to remove it as a timeout request (because it doesn't have a timeout itself).
Just like `invokeSyncImpl`, there are xx operations in the finally block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] BurningCN commented on issue #4194: Suggestions on how invokeAsyncImpl method handles responseFuture
Posted by GitBox <gi...@apache.org>.
BurningCN commented on issue #4194:
URL: https://github.com/apache/rocketmq/issues/4194#issuecomment-1106059851
> When the response is returned, it will be automatically cleared, and the client does not need to actively clear.
>
> https://github.com/apache/rocketmq/blob/2bd9059016448ebcb0bb1cf64ed944eba98bb38e/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java#L294
thanks, got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] pingww commented on issue #4194: Suggestions on how invokeAsyncImpl method handles responseFuture
Posted by GitBox <gi...@apache.org>.
pingww commented on issue #4194:
URL: https://github.com/apache/rocketmq/issues/4194#issuecomment-1106056505
When the response is returned, it will be automatically cleared, and the client does not need to actively clear.
https://github.com/apache/rocketmq/blob/2bd9059016448ebcb0bb1cf64ed944eba98bb38e/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java#L294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] BurningCN closed issue #4194: Suggestions on how invokeAsyncImpl method handles responseFuture
Posted by GitBox <gi...@apache.org>.
BurningCN closed issue #4194: Suggestions on how invokeAsyncImpl method handles responseFuture
URL: https://github.com/apache/rocketmq/issues/4194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org