You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/10/25 07:33:35 UTC
[GitHub] [iceberg] ajantha-bhat opened a new pull request, #6048: Docs: Fix broken link for puffin in Spec
ajantha-bhat opened a new pull request, #6048:
URL: https://github.com/apache/iceberg/pull/6048
`Puffin-spec.md` is in the same directory as `spec.md`.
So, the links were broken as it was looking in the parent directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6048: Docs: Fix broken link for puffin in Spec
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on code in PR #6048:
URL: https://github.com/apache/iceberg/pull/6048#discussion_r1004397117
##########
format/spec.md:
##########
@@ -673,7 +673,7 @@ For serialization details, see Appendix C.
#### Table statistics
-Table statistics files are valid [Puffin files](../puffin-spec). Statistics are informational. A reader can choose to
+Table statistics files are valid [Puffin files](puffin-spec.md). Statistics are informational. A reader can choose to
Review Comment:
I have tagged @samredai for website-related doubts.
I raised this PR because when I browse a `spec.md` file (not from the website) puffin link was broken as it was looking puffin-spec in the parent directory.
I want to have links that work in both website and offline markdown file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on pull request #6048: Docs: Fix broken link for puffin in Spec
Posted by GitBox <gi...@apache.org>.
samredai commented on PR #6048:
URL: https://github.com/apache/iceberg/pull/6048#issuecomment-1295884052
> I want to have links that work in both website and offline markdown file.
@ajantha-bhat this might be difficult to do without changing up at least the way we deploy docs. I'll look into if there's a hugo feature for converting links (We could convert the GitHub-friendly links to site links at build time).
However, the relative paths are not exactly 1:1 between how the markdown files are organized in the repo and how the relative URLs are on the site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #6048: Docs: Fix broken link for puffin in Spec
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on PR #6048:
URL: https://github.com/apache/iceberg/pull/6048#issuecomment-1296078419
> I'll look into if there's a hugo feature for converting links (We could convert the GitHub-friendly links to site links at build time).
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on a diff in pull request #6048: Docs: Fix broken link for puffin in Spec
Posted by GitBox <gi...@apache.org>.
findepi commented on code in PR #6048:
URL: https://github.com/apache/iceberg/pull/6048#discussion_r1004376375
##########
format/spec.md:
##########
@@ -673,7 +673,7 @@ For serialization details, see Appendix C.
#### Table statistics
-Table statistics files are valid [Puffin files](../puffin-spec). Statistics are informational. A reader can choose to
+Table statistics files are valid [Puffin files](puffin-spec.md). Statistics are informational. A reader can choose to
Review Comment:
The website address is https://iceberg.apache.org/puffin-spec/ which is nice.
Will it now be https://iceberg.apache.org/puffin-spec.md (with kind of useless ".md")?
do we plan to also move https://iceberg.apache.org/spec/ to https://iceberg.apache.org/spec.md?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #6048: Docs: Fix broken link for puffin in Spec
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on PR #6048:
URL: https://github.com/apache/iceberg/pull/6048#issuecomment-1292012421
Also cc: @nastra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #6048: Docs: Fix broken link for puffin in Spec
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on PR #6048:
URL: https://github.com/apache/iceberg/pull/6048#issuecomment-1290120300
From the website it works (https://iceberg.apache.org/spec/#table-statistics)
But from the `spec.md` file, it doesn't work. My understanding is that the link should work independently of the website hosting.
cc: @findepi , @samredai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat closed pull request #6048: Docs: Fix broken link for puffin in Spec
Posted by GitBox <gi...@apache.org>.
ajantha-bhat closed pull request #6048: Docs: Fix broken link for puffin in Spec
URL: https://github.com/apache/iceberg/pull/6048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org