You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "vgali7 (via GitHub)" <gi...@apache.org> on 2023/08/03 20:08:25 UTC

[GitHub] [cassandra] vgali7 opened a new pull request, #2547: Cassandra 17684

vgali7 opened a new pull request, #2547:
URL: https://github.com/apache/cassandra/pull/2547

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] bschoening commented on a diff in pull request #2547: Cassandra 17684

Posted by "bschoening (via GitHub)" <gi...@apache.org>.
bschoening commented on code in PR #2547:
URL: https://github.com/apache/cassandra/pull/2547#discussion_r1290409609


##########
pylib/cqlshlib/cqlshmain.py:
##########
@@ -101,10 +101,6 @@
 else:
     DEFAULT_COMPLETEKEY = 'tab'
 
-cqldocs = None
-cqlruleset = None

Review Comment:
   Removing these seems incorrect and/or accidental



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] bschoening commented on a diff in pull request #2547: Cassandra 17684

Posted by "bschoening (via GitHub)" <gi...@apache.org>.
bschoening commented on code in PR #2547:
URL: https://github.com/apache/cassandra/pull/2547#discussion_r1290409609


##########
pylib/cqlshlib/cqlshmain.py:
##########
@@ -101,10 +101,6 @@
 else:
     DEFAULT_COMPLETEKEY = 'tab'
 
-cqldocs = None
-cqlruleset = None

Review Comment:
   Removing these seems incorrect and/or accidental



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org