[GitHub] DaanHoogland commented on a change in pull request #2088: CLOUDSTACK-9892: Primary storage resource check is broken when using ?

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #2088: CLOUDSTACK-9892: Primary storage resource check is broken when using ?
URL: https://github.com/apache/cloudstack/pull/2088#discussion_r160045607
 
 

 ##########
 File path: server/src/com/cloud/vm/UserVmManagerImpl.java
 ##########
 @@ -3283,11 +3295,25 @@ protected UserVm createVirtualMachine(DataCenter zone, ServiceOffering serviceOf
         }
         // check if account/domain is with in resource limits to create a new vm
         boolean isIso = Storage.ImageFormat.ISO == template.getFormat();
-        // For baremetal, size can be null
-        Long tmp = _templateDao.findById(template.getId()).getSize();
         long size = 0;
-        if (tmp != null) {
-            size = tmp;
+        // custom root disk size, resizes base template to larger size
 
 Review comment:
   again I would have liked to see this extracted

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services