[GitHub] [airflow] KevinYang21 edited a comment on issue #5094: [AIRFLOW-4306] Global operator extra links

[GitBox <gi...@apache.org>]

KevinYang21 edited a comment on issue #5094: [AIRFLOW-4306] Global operator extra links
URL: https://github.com/apache/airflow/pull/5094#issuecomment-486025570
 
 
   @feng-tao Took a quick look at the code and I think that's because we start to construct the links from operator instead of from task instance. But since we already have the `execution_date` we can always construct the TI just like other endpoints and use whatever info is inside.
   
   While getting the TI fields is easy, my thinking is still more on the form of the link. The fact that we can just construct a link button right now is probly not going to look very nice when we need some other format, like when we want the download log look for our kibana log links.
   
   EDIT: (hit comment button too soon) I'm not trying to scope out this PR, I think there might be use cases that a link button is enough. If it is not trivial to create such a framework for more complex pluggable components in the dialog it makes sense to start another PR around that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services