You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/09/16 04:38:43 UTC
[GitHub] [iceberg] shardulm94 commented on a change in pull request #1444: Spark: Apply row-level delete files when reading
shardulm94 commented on a change in pull request #1444:
URL: https://github.com/apache/iceberg/pull/1444#discussion_r489146390
##########
File path: data/src/test/java/org/apache/iceberg/data/TestGenericReaderDeletes.java
##########
@@ -108,8 +109,9 @@ public void testEqualityDeletesWithRequiredEqColumn() throws IOException {
.addDeletes(eqDeletes)
.commit();
- StructLikeSet expected = rowSetWithoutIds(29, 89, 122);
- StructLikeSet actual = rowSet(table, "id"); // data is added by the reader to apply the eq deletes
+ StructLikeSet expected = selectColumns(rowSetWithoutIds(29, 89, 122), "id");
+ // data is added by the reader to apply the eq deletes, use StructProjection to remove it from comparison
+ StructLikeSet actual = selectColumns(rowSet(table, "id"), "id");
Review comment:
Any specific reason why we changed this test to remove "data" from comparison?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org