You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whimsical.apache.org by Sam Ruby <ru...@intertwingly.net> on 2016/01/13 20:04:26 UTC
Re: [whimsy.git] [1/1] Commit d0758bf: WHIMSY-34
The good news: your change got deployed.
rubys@whimsy-vm2:~$ ls -l /srv/whimsy/lib/whimsy/asf/committee.rb
/srv/whimsy/www/public/committee-info.json
-rw-r--r-- 1 root root 4610 Jan 13 18:37
/srv/whimsy/lib/whimsy/asf/committee.rb
-rw-rw-r-- 1 www-data www-data 425964 Jan 13 18:45
/srv/whimsy/www/public/committee-info.json
The bad news is that the change didn't work. Fortunately, you already
told me what the bug is, and I've submitted a pull request to update
the working directory used by the cron job:
https://github.com/apache/infrastructure-puppet/pull/47
Hopefully once that change gets applied, the next run will work as intended.
- Sam Ruby
On Wed, Jan 13, 2016 at 1:16 PM, Sebastian Bazley <se...@apache.org> wrote:
> Commit d0758bf734f992e6cc3f5975ba5a203e145b5bef:
> WHIMSY-34
> Spurious data in commitee-info.json
>
>
> Branch: refs/heads/master
> Author: Sebb <se...@apache.org>
> Committer: Sebb <se...@apache.org>
> Pusher: sebb <se...@apache.org>
>
> ------------------------------------------------------------
> lib/whimsy/asf/committee.rb | + -
> ------------------------------------------------------------
> 2 changes: 1 additions, 1 deletions.
> ------------------------------------------------------------
>
>
> diff --git a/lib/whimsy/asf/committee.rb b/lib/whimsy/asf/committee.rb
> index 3cafd86..45613af 100644
> --- a/lib/whimsy/asf/committee.rb
> +++ b/lib/whimsy/asf/committee.rb
> @@ -70,7 +70,7 @@ def self.load_committee_info
> end
>
> # Extract the non-PMC committees (e-mail address may be absent)
> - @nonpmcs = head.sub(/.*?also has/m,'').
> + @nonpmcs = head.sub(/.*?also has /m,'').
> scan(/^[ \t]+(\w.*?)(?:[ \t][ \t]|[ \t]?$)/).flatten.uniq.
> map {|name| list[name]}
>
Re: [whimsy.git] [1/1] Commit d0758bf: WHIMSY-34
Posted by Sam Ruby <ru...@intertwingly.net>.
On Wed, Jan 13, 2016 at 2:04 PM, Sam Ruby <ru...@intertwingly.net> wrote:
> The good news: your change got deployed.
>
> rubys@whimsy-vm2:~$ ls -l /srv/whimsy/lib/whimsy/asf/committee.rb
> /srv/whimsy/www/public/committee-info.json
> -rw-r--r-- 1 root root 4610 Jan 13 18:37
> /srv/whimsy/lib/whimsy/asf/committee.rb
> -rw-rw-r-- 1 www-data www-data 425964 Jan 13 18:45
> /srv/whimsy/www/public/committee-info.json
>
> The bad news is that the change didn't work. Fortunately, you already
> told me what the bug is, and I've submitted a pull request to update
> the working directory used by the cron job:
>
> https://github.com/apache/infrastructure-puppet/pull/47
>
> Hopefully once that change gets applied, the next run will work as intended.
Current status: the cron job updates occurred, and the script didn't
run as they didn't detect any change to sources it tracks.
I've updated the scripts to look for changes in the lib directory.
The change to the script should trigger a run. From that point
forward, you should be able to develop, test, commit, push, and deploy
changes without requiring assistance.
- Sam Ruby
> On Wed, Jan 13, 2016 at 1:16 PM, Sebastian Bazley <se...@apache.org> wrote:
>> Commit d0758bf734f992e6cc3f5975ba5a203e145b5bef:
>> WHIMSY-34
>> Spurious data in commitee-info.json
>>
>>
>> Branch: refs/heads/master
>> Author: Sebb <se...@apache.org>
>> Committer: Sebb <se...@apache.org>
>> Pusher: sebb <se...@apache.org>
>>
>> ------------------------------------------------------------
>> lib/whimsy/asf/committee.rb | + -
>> ------------------------------------------------------------
>> 2 changes: 1 additions, 1 deletions.
>> ------------------------------------------------------------
>>
>>
>> diff --git a/lib/whimsy/asf/committee.rb b/lib/whimsy/asf/committee.rb
>> index 3cafd86..45613af 100644
>> --- a/lib/whimsy/asf/committee.rb
>> +++ b/lib/whimsy/asf/committee.rb
>> @@ -70,7 +70,7 @@ def self.load_committee_info
>> end
>>
>> # Extract the non-PMC committees (e-mail address may be absent)
>> - @nonpmcs = head.sub(/.*?also has/m,'').
>> + @nonpmcs = head.sub(/.*?also has /m,'').
>> scan(/^[ \t]+(\w.*?)(?:[ \t][ \t]|[ \t]?$)/).flatten.uniq.
>> map {|name| list[name]}
>>