You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/05 00:55:34 UTC
[GitHub] [kafka] d8tltanc opened a new pull request #8615: KAFKA-9954: Config command didn't validate the unsupported user config change
d8tltanc opened a new pull request #8615:
URL: https://github.com/apache/kafka/pull/8615
*More detailed description of your change,
Throw an error when users are trying to alter user configs with AdminClient
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
`bin/kafka-configs.sh --bootstrap-server localhost:9092 --alter --add-config producer_byte_rate=44444 --entity-type users --entity-default` will return
> Alternating user configs using AdminClient is not supported yet
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bdbyrne removed a comment on pull request #8615: KAFKA-9954: Config command didn't validate the unsupported user config change
Posted by GitBox <gi...@apache.org>.
bdbyrne removed a comment on pull request #8615:
URL: https://github.com/apache/kafka/pull/8615#issuecomment-624115331
Hi Cheng - what error are you see when trying to modify the "users" quotas? This should be supported, and if not, there's likely another bug that's also affecting "clients".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] d8tltanc commented on pull request #8615: KAFKA-9954: Config command didn't validate the unsupported user config change
Posted by GitBox <gi...@apache.org>.
d8tltanc commented on pull request #8615:
URL: https://github.com/apache/kafka/pull/8615#issuecomment-634304819
closed due to https://github.com/apache/kafka/pull/8628
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #8615: KAFKA-9954: Config command didn't validate the unsupported user config change
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #8615:
URL: https://github.com/apache/kafka/pull/8615#issuecomment-624370846
Please add a unit test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] d8tltanc edited a comment on pull request #8615: KAFKA-9954: Config command didn't validate the unsupported user config change
Posted by GitBox <gi...@apache.org>.
d8tltanc edited a comment on pull request #8615:
URL: https://github.com/apache/kafka/pull/8615#issuecomment-624857586
Thanks for the review. Since we are adding a unit test, move the argument checking in checkArgs()
Edit: Since the existing tests are assuming that alter user entity type is valid with bootstrap server, revoke the change to the original place and test with the command entry point main()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bdbyrne commented on pull request #8615: KAFKA-9954: Config command didn't validate the unsupported user config change
Posted by GitBox <gi...@apache.org>.
bdbyrne commented on pull request #8615:
URL: https://github.com/apache/kafka/pull/8615#issuecomment-624115331
Hi Cheng - what error are you see when trying to modify the "users" quotas? This should be supported, and if not, there's likely another bug that's also affecting "clients".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] d8tltanc commented on pull request #8615: KAFKA-9954: Config command didn't validate the unsupported user config change
Posted by GitBox <gi...@apache.org>.
d8tltanc commented on pull request #8615:
URL: https://github.com/apache/kafka/pull/8615#issuecomment-624857586
Thanks for the review. Since we are adding a unit test, move the argument checking in checkArgs()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] d8tltanc closed pull request #8615: KAFKA-9954: Config command didn't validate the unsupported user config change
Posted by GitBox <gi...@apache.org>.
d8tltanc closed pull request #8615:
URL: https://github.com/apache/kafka/pull/8615
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe edited a comment on pull request #8615: KAFKA-9954: Config command didn't validate the unsupported user config change
Posted by GitBox <gi...@apache.org>.
cmccabe edited a comment on pull request #8615:
URL: https://github.com/apache/kafka/pull/8615#issuecomment-624370846
Please add a junit test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org