You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/15 16:26:20 UTC
[GitHub] [incubator-tvm] ANSHUMAN87 opened a new pull request #5816: Type check added for FloatImm
ANSHUMAN87 opened a new pull request #5816:
URL: https://github.com/apache/incubator-tvm/pull/5816
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #5816: Type check added for FloatImm
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5816:
URL: https://github.com/apache/incubator-tvm/pull/5816#issuecomment-644253039
Thanks @ANSHUMAN87 .There is a reason why we did not add type check to the codebas here(to support custom data types) as show in here.
Closing for now as the PR does not corresponds to a case that we would like to fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #5816: Type check added for FloatImm
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5816:
URL: https://github.com/apache/incubator-tvm/pull/5816#issuecomment-644262612
The other message corrections looks good, please send another PR :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] ANSHUMAN87 commented on pull request #5816: Type check added for FloatImm
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on pull request #5816:
URL: https://github.com/apache/incubator-tvm/pull/5816#issuecomment-644259958
> Thanks @ANSHUMAN87 .There is a reason why we did not add type check to the codebas here(to support custom data types) as show in here.
>
> Closing for now as the PR does not corresponds to a case that we would like to fix.
I believe other error message correction can be taken, those were confusing when i was debugging one issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5816: Type check added for FloatImm
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #5816:
URL: https://github.com/apache/incubator-tvm/pull/5816#discussion_r440316185
##########
File path: tests/python/unittest/test_target_custom_datatypes.py
##########
@@ -128,7 +128,7 @@ def test_bfloat_add_and_cast_FloatImm():
Z = topi.cast(
topi.add(
topi.cast(X, dtype="custom[bfloat]16"),
- tvm.tir.FloatImm("custom[bfloat]16", 1.5)),
+ tvm.tir.FloatImm("float", 1.5)),
Review comment:
There is a reason why we did not add type check to the codebas here(to support custom data types) as show in here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen closed pull request #5816: Type check added for FloatImm
Posted by GitBox <gi...@apache.org>.
tqchen closed pull request #5816:
URL: https://github.com/apache/incubator-tvm/pull/5816
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] ANSHUMAN87 commented on a change in pull request #5816: Type check added for FloatImm
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on a change in pull request #5816:
URL: https://github.com/apache/incubator-tvm/pull/5816#discussion_r440324179
##########
File path: tests/python/unittest/test_target_custom_datatypes.py
##########
@@ -128,7 +128,7 @@ def test_bfloat_add_and_cast_FloatImm():
Z = topi.cast(
topi.add(
topi.cast(X, dtype="custom[bfloat]16"),
- tvm.tir.FloatImm("custom[bfloat]16", 1.5)),
+ tvm.tir.FloatImm("float", 1.5)),
Review comment:
I am sorry, i did not understand completely the logic behind it. I mean how FloatImm can support datatype other than float. It looks like some potential hole. That is why i added check. Anyway if it is on purpose, then i will ignore it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org