You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@systemds.apache.org by ss...@apache.org on 2022/08/02 15:17:55 UTC
[systemds] branch main updated: [SYSTEMDS-3415] Fix for built-in tests failure in Git actions - This commit contains fixes for failing functions.builtin.part2 tests - It install the missing library to fix failing R tests and ignore the tomeklink tests with a TODO
This is an automated email from the ASF dual-hosted git repository.
ssiddiqi pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/systemds.git
The following commit(s) were added to refs/heads/main by this push:
new 1c07e5b249 [SYSTEMDS-3415] Fix for built-in tests failure in Git actions - This commit contains fixes for failing functions.builtin.part2 tests - It install the missing library to fix failing R tests and ignore the tomeklink tests with a TODO
1c07e5b249 is described below
commit 1c07e5b249b78c9b192aab21e2d52115525e0d08
Author: Shafaq Siddiqi <sh...@tugraz.at>
AuthorDate: Tue Aug 2 16:41:14 2022 +0200
[SYSTEMDS-3415] Fix for built-in tests failure in Git actions
- This commit contains fixes for failing functions.builtin.part2 tests
- It install the missing library to fix failing R tests and ignore the tomeklink tests with a TODO
---
docker/testsysds.Dockerfile | 8 +++++---
.../sysds/test/functions/builtin/part2/BuiltinTomeklinkTest.java | 8 +++++---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/docker/testsysds.Dockerfile b/docker/testsysds.Dockerfile
index 2bfabebc2b..373548f35c 100644
--- a/docker/testsysds.Dockerfile
+++ b/docker/testsysds.Dockerfile
@@ -64,12 +64,14 @@ RUN apt-get update -qq \
http://archive.apache.org/dist/maven/maven-3/$MAVEN_VERSION/binaries/apache-maven-$MAVEN_VERSION-bin.tar.gz | tar xzf - \
&& mv apache-maven-$MAVEN_VERSION /usr/lib/mvn
-# R
RUN apt-get install -y --no-install-recommends \
- r-base \
+ libssl-dev \
+ r-base \
r-base-dev \
+ r-base-core\
+
&& Rscript installDependencies.R \
&& rm -rf installDependencies.R \
&& rm -rf /var/lib/apt/lists/*
-ENTRYPOINT ["/entrypoint.sh"]
+ENTRYPOINT ["/entrypoint.sh"]
\ No newline at end of file
diff --git a/src/test/java/org/apache/sysds/test/functions/builtin/part2/BuiltinTomeklinkTest.java b/src/test/java/org/apache/sysds/test/functions/builtin/part2/BuiltinTomeklinkTest.java
index 5f5076123e..457c71b6a8 100644
--- a/src/test/java/org/apache/sysds/test/functions/builtin/part2/BuiltinTomeklinkTest.java
+++ b/src/test/java/org/apache/sysds/test/functions/builtin/part2/BuiltinTomeklinkTest.java
@@ -19,6 +19,7 @@
package org.apache.sysds.test.functions.builtin.part2;
+import org.junit.Ignore;
import org.junit.Test;
import org.apache.sysds.common.Types.ExecMode;
import org.apache.sysds.common.Types.ExecType;
@@ -43,13 +44,14 @@ public class BuiltinTomeklinkTest extends AutomatedTestBase
public void setUp() {
addTestConfiguration(TEST_NAME,new TestConfiguration(TEST_CLASS_DIR, TEST_NAME,new String[]{"B"}));
}
-
- @Test
+ //TODO as the cran repository is no linger hosting the R package "unbalanced" these tests are failing
+ // the fix needs to be either install the package hosted on Git or rewrite test/script with other R package
+ @Ignore
public void testTomeklinkCP() {
runTomeklinkTest(ExecType.CP);
}
- @Test
+ @Ignore
public void testTomeklinkSP() {
runTomeklinkTest(ExecType.SPARK);
}