You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <hu...@gmail.com> on 2015/12/14 22:33:22 UTC
Review Request 41366: GEODE-653: Add unit test for GMSHealthMonitor
checkIfAvailable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41366/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, and Jianxia Chen.
Repository: geode
Description
-------
Modified and added test for checkIfAvailable
Removed dead code
minor doc edit/correction
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java 8c38ba6
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java eb17ca8
Diff: https://reviews.apache.org/r/41366/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 41366: GEODE-653: Add unit test for
GMSHealthMonitor checkIfAvailable
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41366/#review110584
-----------------------------------------------------------
Ship it!
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java (line 421)
<https://reviews.apache.org/r/41366/#comment170532>
change the assertion failure text to show what memberTimeout is?
- Bruce Schuchardt
On Dec. 14, 2015, 9:33 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41366/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2015, 9:33 p.m.)
>
>
> Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, and Jianxia Chen.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Modified and added test for checkIfAvailable
> Removed dead code
> minor doc edit/correction
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java 8c38ba6
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java eb17ca8
>
> Diff: https://reviews.apache.org/r/41366/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>