You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/12/15 21:06:22 UTC
[GitHub] [kafka] wcarlson5 opened a new pull request #11604: MINOR: retry when deleting offsets for named topologies
wcarlson5 opened a new pull request #11604:
URL: https://github.com/apache/kafka/pull/11604
When this was made I didn't expect deleteOffsetsResult to be set if an exception was thrown. But it is and to retry we need to reset it to null.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a change in pull request #11604: MINOR: retry when deleting offsets for named topologies
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on a change in pull request #11604:
URL: https://github.com/apache/kafka/pull/11604#discussion_r770929975
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java
##########
@@ -221,9 +222,14 @@ public RemoveNamedTopologyResult removeNamedTopology(final String topologyToRemo
.getMessage()
.equals("Deleting offsets of a topic is forbidden while the consumer group is actively subscribed to it.")) {
ex.printStackTrace();
+ } else if (ex.getCause() != null &&
+ ex.getCause() instanceof GroupIdNotFoundException) {
+ log.debug("The offsets have been reset and it retied again, no longer retrying.");
Review comment:
```suggestion
log.debug("The offsets have been reset by another client or the group has been deleted, no need to retry further.");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wcarlson5 commented on pull request #11604: MINOR: retry when deleting offsets for named topologies
Posted by GitBox <gi...@apache.org>.
wcarlson5 commented on pull request #11604:
URL: https://github.com/apache/kafka/pull/11604#issuecomment-995213697
@ableegoldman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #11604: MINOR: retry when deleting offsets for named topologies
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #11604:
URL: https://github.com/apache/kafka/pull/11604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11604: MINOR: retry when deleting offsets for named topologies
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11604:
URL: https://github.com/apache/kafka/pull/11604#issuecomment-995420047
Hm, guess we should have seen this coming but it looks like this fix is significantly increasing the flakiness of `NamedTopologyIntegrationTest.shouldRemoveNamedTopologyToRunningApplicationWithMultipleNodesAndResetsOffsets()` since retrying makes us more likely to hit the `GroupIdNotFoundException: The group id does not exist.` type. So I guess we'll need to address them in the same PR after all. :/
The good news is, I'm pretty sure I understand why this is happening, and _hopefully_ it will be a simple fix. I'm going to ping David in the core team slack to verify my theory and make sure we can do the "simple fix", I'll tag you as well for the fully story
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org