[GitHub] [spark] andylam-db commented on pull request #39571: [SPARK-42064][SQL] Implement bloom filter join hint

["andylam-db (via GitHub)" <gi...@apache.org>]

andylam-db commented on PR #39571:
URL: https://github.com/apache/spark/pull/39571#issuecomment-1416386966

   1. How is this join hint resolved if it has >1 parameters? E.g.
   ```SELECT /*+ BLOOM_FILTER_JOIN(r, s) */ * FROM records r JOIN src s ON r.key = s.key```
   2. +1 for @ulysses-you comments: `filteringHasBenefit` can still prevent the runtime filter from being built even with the hint. I think we should either bypass `filteringHasBenefit` with the hint, or show warn logs if the hint does not work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org