You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "srielau (via GitHub)" <gi...@apache.org> on 2023/05/16 23:25:04 UTC

[GitHub] [spark] srielau commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

srielau commented on code in PR #41007:
URL: https://github.com/apache/spark/pull/41007#discussion_r1195776805


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala:
##########
@@ -40,18 +40,34 @@ case class UnresolvedNamespace(multipartIdentifier: Seq[String]) extends LeafNod
   override def output: Seq[Attribute] = Nil
 }
 
+abstract class UnresolvedTableOrIdentifierClause extends LeafNode
+
 /**
  * Holds the name of a table that has yet to be looked up in a catalog. It will be resolved to
  * [[ResolvedTable]] during analysis.
  */
 case class UnresolvedTable(
     multipartIdentifier: Seq[String],
     commandName: String,
-    relationTypeMismatchHint: Option[String]) extends LeafNode {
+    relationTypeMismatchHint: Option[String]) extends UnresolvedTableOrIdentifierClause {
   override lazy val resolved: Boolean = false
 
   override def output: Seq[Attribute] = Nil
 }
+/**
+ * Holds the identifier of a tabl ein String form that has yet to be looked up in a catalog.

Review Comment:
   Adressed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org