You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@xmlgraphics.apache.org by bu...@apache.org on 2009/12/17 14:57:23 UTC
DO NOT REPLY [Bug 48405] New: Implement a color conversion utility
https://issues.apache.org/bugzilla/show_bug.cgi?id=48405
Summary: Implement a color conversion utility
Product: XMLGraphicsCommons
Version: Trunk
Platform: All
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P2
Component: Utilities
AssignedTo: general@xmlgraphics.apache.org
ReportedBy: peter.hancock@gmail.com
awt.Color conversion is repetitively re-implemented in the fop code-base. It
would be useful to have a common interface for providing this functionality
that could be used in the XMLGraphics child projects.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 48405] Implement a color conversion utility
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48405
Peter Hancock <pe...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--- Comment #4 from Peter Hancock <pe...@gmail.com> 2010-01-08 02:32:24 UTC ---
Updated patch
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 48405] Implement a color conversion utility
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48405
Chris Bowditch <bo...@hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #5 from Chris Bowditch <bo...@hotmail.com> 2010-01-08 05:44:20 UTC ---
Thanks for the updated Patch Peter. The inclusion of the implementations makes
more sense now. Patch committed in revision 897202
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 48405] Implement a color conversion utility
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48405
Chris Bowditch <bo...@hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #2 from Chris Bowditch <bo...@hotmail.com> 2010-01-07 06:46:22 UTC ---
Hi Peter,
I've taken a look at your patch and there are a number of checkstyle warnings
about the use of tabs and trailing spaces. If you haven't done so already I
suggest you enable checkstyle integration with your Java IDE and check the
checkstyle report prior to submitting any patches.
No need to submit a new patch just for checkstyle as I have corrected the
checkstyle warnings locally. However, I am wondering why you have placed only
the Interface into commons and put the implementations into FOP? Wouldn't it
more make sense to put the implementations into commons too. I see they have a
dependency on the ColorUtil.toCMYKGrayColor method in FOP, but that could be
moved to a super class of ColorUtil that lives in commons. The move should be
easy enough as your converter class appears to be the only user of that method.
Chris
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 48405] Implement a color conversion utility
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48405
Chris Bowditch <bo...@hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |48237
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 48405] Implement a color conversion utility
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48405
Peter Hancock <pe...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24724|0 |1
is obsolete| |
--- Comment #3 from Peter Hancock <pe...@gmail.com> 2010-01-08 02:30:06 UTC ---
Created an attachment (id=24817)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=24817)
A ColorConverter interface with some generic implementations
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 48405] Implement a color conversion utility
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48405
--- Comment #1 from Peter Hancock <pe...@gmail.com> 2009-12-17 05:59:47 UTC ---
Created an attachment (id=24724)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=24724)
A color coverter interface
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org