You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/02 14:36:18 UTC

[GitHub] [shardingsphere] avalon5666 opened a new pull request #5894: Implement persistence task position info

avalon5666 opened a new pull request #5894:
URL: https://github.com/apache/shardingsphere/pull/5894


   For #5446.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #5894: Implement persistence task position info

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #5894:
URL: https://github.com/apache/shardingsphere/pull/5894#issuecomment-637598979


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5894?src=pr&el=h1) Report
   > Merging [#5894](https://codecov.io/gh/apache/shardingsphere/pull/5894?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/04eb9c4ed90375a81e747a2f49481532f00614b6&el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `55.26%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5894/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5894?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5894      +/-   ##
   ============================================
   - Coverage     53.03%   53.03%   -0.01%     
   - Complexity      439      440       +1     
   ============================================
     Files          1182     1184       +2     
     Lines         20761    20784      +23     
     Branches       3736     3738       +2     
   ============================================
   + Hits          11010    11022      +12     
   - Misses         9073     9082       +9     
   - Partials        678      680       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5894?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../execute/executor/channel/DistributionChannel.java](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL2NoYW5uZWwvRGlzdHJpYnV0aW9uQ2hhbm5lbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ng/core/execute/executor/dumper/DumperFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL2R1bXBlci9EdW1wZXJGYWN0b3J5LmphdmE=) | `30.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...aling/core/execute/executor/record/DataRecord.java](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL3JlY29yZC9EYXRhUmVjb3JkLmphdmE=) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...g/core/execute/executor/record/FinishedRecord.java](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL3JlY29yZC9GaW5pc2hlZFJlY29yZC5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...ore/execute/executor/record/PlaceholderRecord.java](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL3JlY29yZC9QbGFjZWhvbGRlclJlY29yZC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../core/job/preparer/ShardingScalingJobPreparer.java](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcHJlcGFyZXIvU2hhcmRpbmdTY2FsaW5nSm9iUHJlcGFyZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../scaling/core/job/task/DefaultSyncTaskFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvdGFzay9EZWZhdWx0U3luY1Rhc2tGYWN0b3J5LmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...b/task/incremental/IncrementalDataScalingTask.java](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvdGFzay9pbmNyZW1lbnRhbC9JbmNyZW1lbnRhbERhdGFTY2FsaW5nVGFzay5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ob/task/incremental/LogPositionManagerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvdGFzay9pbmNyZW1lbnRhbC9Mb2dQb3NpdGlvbk1hbmFnZXJGYWN0b3J5LmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | [...e/shardingsphere/scaling/mysql/BinlogPosition.java](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL0JpbmxvZ1Bvc2l0aW9uLmphdmE=) | `57.14% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [16 more](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5894?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5894?src=pr&el=footer). Last update [04eb9c4...0cf8252](https://codecov.io/gh/apache/shardingsphere/pull/5894?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #5894: Implement persistence task position info

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #5894:
URL: https://github.com/apache/shardingsphere/pull/5894#issuecomment-637598979


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5894?src=pr&el=h1) Report
   > Merging [#5894](https://codecov.io/gh/apache/shardingsphere/pull/5894?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/04eb9c4ed90375a81e747a2f49481532f00614b6&el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `55.26%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5894/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5894?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5894      +/-   ##
   ============================================
   - Coverage     53.03%   53.03%   -0.01%     
   - Complexity      439      440       +1     
   ============================================
     Files          1182     1184       +2     
     Lines         20761    20784      +23     
     Branches       3736     3738       +2     
   ============================================
   + Hits          11010    11022      +12     
   - Misses         9073     9082       +9     
   - Partials        678      680       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5894?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../execute/executor/channel/DistributionChannel.java](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL2NoYW5uZWwvRGlzdHJpYnV0aW9uQ2hhbm5lbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ng/core/execute/executor/dumper/DumperFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL2R1bXBlci9EdW1wZXJGYWN0b3J5LmphdmE=) | `30.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...aling/core/execute/executor/record/DataRecord.java](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL3JlY29yZC9EYXRhUmVjb3JkLmphdmE=) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...g/core/execute/executor/record/FinishedRecord.java](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL3JlY29yZC9GaW5pc2hlZFJlY29yZC5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...ore/execute/executor/record/PlaceholderRecord.java](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL3JlY29yZC9QbGFjZWhvbGRlclJlY29yZC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../core/job/preparer/ShardingScalingJobPreparer.java](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcHJlcGFyZXIvU2hhcmRpbmdTY2FsaW5nSm9iUHJlcGFyZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../scaling/core/job/task/DefaultSyncTaskFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvdGFzay9EZWZhdWx0U3luY1Rhc2tGYWN0b3J5LmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...b/task/incremental/IncrementalDataScalingTask.java](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvdGFzay9pbmNyZW1lbnRhbC9JbmNyZW1lbnRhbERhdGFTY2FsaW5nVGFzay5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ob/task/incremental/LogPositionManagerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvdGFzay9pbmNyZW1lbnRhbC9Mb2dQb3NpdGlvbk1hbmFnZXJGYWN0b3J5LmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | [...e/shardingsphere/scaling/mysql/BinlogPosition.java](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL0JpbmxvZ1Bvc2l0aW9uLmphdmE=) | `57.14% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [16 more](https://codecov.io/gh/apache/shardingsphere/pull/5894/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5894?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5894?src=pr&el=footer). Last update [04eb9c4...0cf8252](https://codecov.io/gh/apache/shardingsphere/pull/5894?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] KomachiSion commented on a change in pull request #5894: Implement persistence task position info

Posted by GitBox <gi...@apache.org>.
KomachiSion commented on a change in pull request #5894:
URL: https://github.com/apache/shardingsphere/pull/5894#discussion_r434255577



##########
File path: shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/job/task/incremental/LogPositionManager.java
##########
@@ -15,25 +15,20 @@
  * limitations under the License.
  */
 
-package org.apache.shardingsphere.scaling.core.job.position;

Review comment:
       Position is also used in job preparer, so I think it should not be move to incremental task package.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] avalon5666 commented on a change in pull request #5894: Implement persistence task position info

Posted by GitBox <gi...@apache.org>.
avalon5666 commented on a change in pull request #5894:
URL: https://github.com/apache/shardingsphere/pull/5894#discussion_r434579223



##########
File path: shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/job/task/incremental/LogPositionManager.java
##########
@@ -15,25 +15,20 @@
  * limitations under the License.
  */
 
-package org.apache.shardingsphere.scaling.core.job.position;

Review comment:
       The LogPosition manager is the util to get current binlog(wal) position from database. I haven't found the suitable naming for it yet, just adjuest the package.
   Now the task position metadata manager is different class, the manager will refactor soon.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] avalon5666 closed pull request #5894: Implement persistence task position info

Posted by GitBox <gi...@apache.org>.
avalon5666 closed pull request #5894:
URL: https://github.com/apache/shardingsphere/pull/5894


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org