[jira] [Commented] (KYLIN-5353) Failed to save model which contains computed column using functions of timestampadd or timestampdiff

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675898#comment-17675898 ] 

ASF subversion and git services commented on KYLIN-5353:
--------------------------------------------------------

Commit 092bbed4787b4db434b5cc06b356ec0a75462523 in kylin's branch refs/heads/kylin5 from Dorris Zhang
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=092bbed478 ]

KYLIN-5353 add UT


> Failed to save model which contains computed column using functions of timestampadd or timestampdiff 
> -----------------------------------------------------------------------------------------------------
>
>                 Key: KYLIN-5353
>                 URL: https://issues.apache.org/jira/browse/KYLIN-5353
>             Project: Kylin
>          Issue Type: Bug
>          Components: Modeling
>    Affects Versions: 5.0-alpha
>            Reporter: pengfei.zhan
>            Assignee: pengfei.zhan
>            Priority: Major
>             Fix For: 5.0-alpha
>
>         Attachments: kylin5.jpeg
>
>
> When saving the model containing some computed columns using functions of `timestampdiff` or `timestampadd`, it failed with throwing an exception as follows.
> !kylin5.jpeg!
> This happens because `ModelSemanticHelper#discardInvalidComputedColumnsForBrokenModel` used the `innerExpression` of the computed column other than `expression`. By design, the `innerExpression` is used for spark, the expression used by calcite parser.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)