You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/02 17:57:09 UTC

[GitHub] [beam] aromanenko-dev commented on pull request #16077: [BEAM-13175] Add KinesisIO.write for AWS SDK v2.

aromanenko-dev commented on pull request #16077:
URL: https://github.com/apache/beam/pull/16077#issuecomment-1057214170


   @mosche Great progress, many thanks for details!
   
   > I'm enforcing Beam's version of Netty over the more recent one used by AWS. In my tests this worked very well.
   
   I think it should be fine.
   
   > Another change is the output type of the writer. As recommended [here](https://docs.google.com/document/d/1V2FkGGunVgvLwi1dKHr-7mtDuwYjTuvuESV_oPzVnfQ/edit?resourcekey=0-KvfQq-5iCcMlu3f3MFJ-GQ#heading=h.xl97lw3dyot7) i changed it from Void to Result to allow for future backwards compatible changes. Currently the writer is fail fast (after retries of course), but adding a deadletter output would make sense...
   
   Totally agree with that.
   
   > The next step is to provide a more powerful internal partitioner that is aware of hashkey ranges assigned to KinesisShards.
   
   Do you think it would make sense to do as a separate PR?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org