You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by JunHe77 <gi...@git.apache.org> on 2018/10/03 15:46:24 UTC
[GitHub] bigtop pull request #402: BIGTOP-3089: Update provision config files with ch...
GitHub user JunHe77 opened a pull request:
https://github.com/apache/bigtop/pull/402
BIGTOP-3089: Update provision config files with changes in 1.3.0 release
v1.3.0 supports: centos-7, fedora-26, debian-9, ubuntu-16.04, opensuse-42.3
config files in provisioner/docker should be updated to sync with these changes
Change-Id: Ic5d66cb837e78908fcf19c2e55f819db28866a55
Signed-off-by: Jun He <ju...@linaro.org>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JunHe77/bigtop BIGTOP-3089
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bigtop/pull/402.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #402
----
commit 6e20d01f3fbfd6dee4487aea47405040fd15e25c
Author: Jun He <ju...@...>
Date: 2018-10-03T12:52:33Z
BIGTOP-3089: Update provision config files with changes in 1.3.0 release
v1.3.0 supports: centos-7, fedora-26, debian-9, ubuntu-16.04, opensuse-42.3
config files in provisioner/docker should be updated to sync with these changes
Change-Id: Ic5d66cb837e78908fcf19c2e55f819db28866a55
Signed-off-by: Jun He <ju...@linaro.org>
----
---
[GitHub] bigtop pull request #402: BIGTOP-3089: Update provision config files with ch...
Posted by JunHe77 <gi...@git.apache.org>.
Github user JunHe77 commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/402#discussion_r222637627
--- Diff: provisioner/docker/config_fedora-26.yaml ---
@@ -14,10 +14,10 @@
# limitations under the License.
docker:
- memory_limit: "4g"
- image: "bigtop/puppet:trunk-centos-6"
+ memory_limit: "8g"
+ image: "bigtop/puppet:1.3.0-fedora-26"
-repo: "http://repos.bigtop.apache.org/releases/1.2.1/centos/6/x86_64"
+repo: "http://repos.bigtop.apache.org/releases/1.3.0/fedora/26/$basearch"
--- End diff --
Using $ARCH to automatically load different architecture repo on deb systems is verified on x86_64, aarch64 and ppc64le.
Patch is updated. "docker-hadoop.sh" is modified to load correct puppet image by detecting CPU arch. This makes only one config file is needed for a certain distro acrossing different architectures.
Pls review. Thanks.
---
[GitHub] bigtop pull request #402: BIGTOP-3089: Update provision config files with ch...
Posted by epikhinm <gi...@git.apache.org>.
Github user epikhinm commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/402#discussion_r222590103
--- Diff: provisioner/docker/config_fedora-26.yaml ---
@@ -14,10 +14,10 @@
# limitations under the License.
docker:
- memory_limit: "4g"
- image: "bigtop/puppet:trunk-centos-6"
+ memory_limit: "8g"
+ image: "bigtop/puppet:1.3.0-fedora-26"
-repo: "http://repos.bigtop.apache.org/releases/1.2.1/centos/6/x86_64"
+repo: "http://repos.bigtop.apache.org/releases/1.3.0/fedora/26/$basearch"
--- End diff --
Debian-based distro's support $(ARCH) variable https://manpages.debian.org/jessie/apt/sources.list.5.en.html
---
[GitHub] bigtop pull request #402: BIGTOP-3089: Update provision config files with ch...
Posted by JunHe77 <gi...@git.apache.org>.
Github user JunHe77 commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/402#discussion_r222539413
--- Diff: provisioner/docker/config_fedora-26.yaml ---
@@ -14,10 +14,10 @@
# limitations under the License.
docker:
- memory_limit: "4g"
- image: "bigtop/puppet:trunk-centos-6"
+ memory_limit: "8g"
+ image: "bigtop/puppet:1.3.0-fedora-26"
-repo: "http://repos.bigtop.apache.org/releases/1.2.1/centos/6/x86_64"
+repo: "http://repos.bigtop.apache.org/releases/1.3.0/fedora/26/$basearch"
--- End diff --
rpm base distros support using $basearch to automatically load arch dependent repo:
https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/6/html/deployment_guide/sec-using_yum_variables
while for apt it doesn't use this way.
The target is to unified configurations/deployment across different architectures for a same distro. So this patch starts from rpm based distros (centos/fedora/opensuse)
---
[GitHub] bigtop pull request #402: BIGTOP-3089: Update provision config files with ch...
Posted by evans-ye <gi...@git.apache.org>.
Github user evans-ye commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/402#discussion_r222529631
--- Diff: provisioner/docker/config_centos-7.yaml ---
@@ -14,10 +14,10 @@
# limitations under the License.
docker:
- memory_limit: "4g"
- image: "bigtop/puppet:trunk-centos-7"
+ memory_limit: "8g"
--- End diff --
Let's stick with 4g here.
---
[GitHub] bigtop pull request #402: BIGTOP-3089: Update provision config files with ch...
Posted by evans-ye <gi...@git.apache.org>.
Github user evans-ye commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/402#discussion_r222529962
--- Diff: provisioner/docker/config_fedora-26.yaml ---
@@ -14,10 +14,10 @@
# limitations under the License.
docker:
- memory_limit: "4g"
- image: "bigtop/puppet:trunk-centos-6"
+ memory_limit: "8g"
+ image: "bigtop/puppet:1.3.0-fedora-26"
-repo: "http://repos.bigtop.apache.org/releases/1.2.1/centos/6/x86_64"
+repo: "http://repos.bigtop.apache.org/releases/1.3.0/fedora/26/$basearch"
--- End diff --
I can't figure out why some are $basearch and some are still x86_64. What's the rule here?
---
[GitHub] bigtop pull request #402: BIGTOP-3089: Update provision config files with ch...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bigtop/pull/402
---
[GitHub] bigtop pull request #402: BIGTOP-3089: Update provision config files with ch...
Posted by JunHe77 <gi...@git.apache.org>.
Github user JunHe77 commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/402#discussion_r222602799
--- Diff: provisioner/docker/config_fedora-26.yaml ---
@@ -14,10 +14,10 @@
# limitations under the License.
docker:
- memory_limit: "4g"
- image: "bigtop/puppet:trunk-centos-6"
+ memory_limit: "8g"
+ image: "bigtop/puppet:1.3.0-fedora-26"
-repo: "http://repos.bigtop.apache.org/releases/1.2.1/centos/6/x86_64"
+repo: "http://repos.bigtop.apache.org/releases/1.3.0/fedora/26/$basearch"
--- End diff --
@epikhinm that's a good point. I didn't realize $ARCH can be used in repo url. Just thought I can only specify what kind of arch a certain repo supports, lie "arch=arch1,arch2".
Thanks for the suggestion and I will test and update new patch if it is OK for auto loading.
---