You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/07/15 20:02:38 UTC

Review Request 23512: Update docker uri to expect 3 slashes in prefix

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23512/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Yifan Gu.


Bugs: MESOS-1524
    https://issues.apache.org/jira/browse/MESOS-1524


Repository: mesos-git


Description
-------

Update docker uri to expect 3 slashes in prefix.

This is to be compatiable with how Docker URIs are expected with current external containerizer and Deimos, and can easily transition to the new Docker implementation. 


Diffs
-----

  src/examples/docker_no_executor_framework.cpp PRE-CREATION 
  src/slave/containerizer/docker.cpp PRE-CREATION 
  src/tests/docker_containerizer_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/23512/diff/


Testing
-------

make check


Thanks,

Timothy Chen

Re: Review Request 23512: Update docker uri to expect 3 slashes in prefix

Posted by Timothy Chen <tn...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23512/
-----------------------------------------------------------

(Updated July 17, 2014, 6:20 p.m.)


Review request for mesos, Benjamin Hindman and Yifan Gu.


Bugs: MESOS-1524
    https://issues.apache.org/jira/browse/MESOS-1524


Repository: mesos-git


Description
-------

Update docker uri to expect 3 slashes in prefix.

This is to be compatiable with how Docker URIs are expected with current external containerizer and Deimos, and can easily transition to the new Docker implementation. 


Diffs
-----

  src/examples/docker_no_executor_framework.cpp PRE-CREATION 
  src/slave/containerizer/docker.cpp PRE-CREATION 
  src/tests/docker_containerizer_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/23512/diff/


Testing
-------

make check


Thanks,

Timothy Chen

Re: Review Request 23512: Update docker uri to expect 3 slashes in prefix

Posted by Mesos ReviewBot <de...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23512/#review47897
-----------------------------------------------------------


Bad patch!

Reviews applied: [23512]

Failed command: git apply --index 23512.patch

Error:
 error: src/examples/docker_no_executor_framework.cpp: does not exist in index
error: src/slave/containerizer/docker.cpp: does not exist in index
error: src/tests/docker_containerizer_tests.cpp: does not exist in index


- Mesos ReviewBot


On July 15, 2014, 6:02 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23512/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, 6:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Yifan Gu.
> 
> 
> Bugs: MESOS-1524
>     https://issues.apache.org/jira/browse/MESOS-1524
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Update docker uri to expect 3 slashes in prefix.
> 
> This is to be compatiable with how Docker URIs are expected with current external containerizer and Deimos, and can easily transition to the new Docker implementation. 
> 
> 
> Diffs
> -----
> 
>   src/examples/docker_no_executor_framework.cpp PRE-CREATION 
>   src/slave/containerizer/docker.cpp PRE-CREATION 
>   src/tests/docker_containerizer_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23512/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>