[GitHub] [superset] zhaoyongjie commented on a change in pull request #18846: fix: lost url_params after long-url feature

[GitBox <gi...@apache.org>]

zhaoyongjie commented on a change in pull request #18846:
URL: https://github.com/apache/superset/pull/18846#discussion_r811835791



##########
File path: superset/views/core.py
##########
@@ -744,8 +744,7 @@ def explore(
         if form_data_key:
             parameters = CommandParameters(actor=g.user, key=form_data_key,)
             value = GetFormDataCommand(parameters).run()
-            if value:
-                initial_form_data = json.loads(value)
+            initial_form_data = json.loads(value) if value else {}

Review comment:
       just code smell




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org