You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/07/07 19:53:02 UTC
[GitHub] [netbeans] KacerCZ commented on a change in pull request #2231: [NETBEANS-4340] Added PHP Mess Detector options configuration
KacerCZ commented on a change in pull request #2231:
URL: https://github.com/apache/netbeans/pull/2231#discussion_r451105994
##########
File path: php/php.code.analysis/src/org/netbeans/modules/php/analysis/MessDetectorAnalyzerImpl.java
##########
@@ -223,6 +224,20 @@ private FileObject getValidRuleSetFile() {
return FileUtil.toFileObject(new File(ruleSetFile));
}
+ @CheckForNull
+ private String getValidOptions() {
+ String options = null;
+ Preferences settings = context.getSettings();
+ if (settings != null) {
+ options = settings.get(MessDetectorCustomizerPanel.OPTIONS, null);
+ }
+ if (options == null) {
+ options = AnalysisOptions.getInstance().getMessDetectorOptions();
+ }
+ assert options != null;
Review comment:
I removed the assert.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists