You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Aleksei Zotov (Jira)" <ji...@apache.org> on 2021/09/27 13:36:00 UTC

[jira] [Comment Edited] (CASSANDRA-16995) Add tests for Resource fromName/getName

    [ https://issues.apache.org/jira/browse/CASSANDRA-16995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17420742#comment-17420742 ] 

Aleksei Zotov edited comment on CASSANDRA-16995 at 9/27/21, 1:35 PM:
---------------------------------------------------------------------

Ok, backporting to the previous version makes sense.

After a private discussion with [~bereng] I backported CASSANDRA-16977 to 3.0 to make this test working there.

Here are the changes and CI: 
||Branch||PR||CI||
|3.0|[PR-1227|https://github.com/apache/cassandra/pull/1227]|[CI-1148|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1148/]|
|3.11|[PR-1226|https://github.com/apache/cassandra/pull/1226]|[CI-1149|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1149/]|
|4.0|[PR-1225|https://github.com/apache/cassandra/pull/1225]|[CI-1150|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1150/]|
|trunk|[PR-1219|https://github.com/apache/cassandra/pull/1219]|[CI-1145|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1145/]|

Please, take a look to the PRs and let me know if we're good to go with the merge.
  


was (Author: azotcsit):
Ok, backporting to the previous version makes sense.

After a private discussion with [~bereng] I backported CASSANDRA-16977 to 3.0 to make this test working there.

Here are the changes and CI:

 
||Branch||PR||CI||
|3.0|https://github.com/apache/cassandra/pull/1227|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1148/|
|3.11|https://github.com/apache/cassandra/pull/1226|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1149/|
|4.0|https://github.com/apache/cassandra/pull/1225|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1150/|
|trunk|https://github.com/apache/cassandra/pull/1219|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1145/|

 

Please, take a look to the PRs and let me know if we're good to go with the merge.

 

> Add tests for Resource fromName/getName
> ---------------------------------------
>
>                 Key: CASSANDRA-16995
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16995
>             Project: Cassandra
>          Issue Type: Task
>          Components: Test/unit
>            Reporter: Aleksei Zotov
>            Assignee: Aleksei Zotov
>            Priority: Low
>             Fix For: 4.x
>
>
> As a part of CASSANDRA-16977 we identified a problem functions ({{FunctionResource.fromName}}) parsing logic. We agreed that {{Resource.fromName/}}{{Resource.getName}} should be symmetrical. I'd like to ensure that by having a corresponding unit test.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org