[GitHub] spark pull request: [SPARK-5093] Set spark.network.timeout to 120s...

[lianhuiwang <gi...@git.apache.org>]

Github user lianhuiwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3903#discussion_r23982799
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala ---
    @@ -52,11 +52,7 @@ class BlockManagerMasterActor(val isLocal: Boolean, conf: SparkConf, listenerBus
     
       private val akkaTimeout = AkkaUtils.askTimeout(conf)
     
    -  val slaveTimeout = {
    -    val defaultMs = math.max(conf.getInt("spark.executor.heartbeatInterval", 10000) * 3, 45000)
    -    val networkTimeout = conf.getInt("spark.network.timeout", defaultMs / 1000)
    -    conf.getLong("spark.storage.blockManagerSlaveTimeoutMs", networkTimeout * 1000)
    -  }
    +  val slaveTimeout = conf.getLong("spark.storage.blockManagerSlaveTimeoutMs", 120 * 1000)
    --- End diff --
    
    if user do not set blockManagerSlaveTimeoutMs, i think we need to set spark.network.timeout to blockManagerSlaveTimeoutMs. if spark.network.timeout is not defined, we can set the default 120 to spark.network.timeout. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org