You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/08/30 10:47:25 UTC

[GitHub] [ignite] nizhikov opened a new pull request #9360: IGNITE-14725 Server node fail when user send unsupported class version

nizhikov opened a new pull request #9360:
URL: https://github.com/apache/ignite/pull/9360


   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [ ] There is a single JIRA ticket related to the pull request. 
   - [ ] The web-link to the pull request is attached to the JIRA ticket.
   - [ ] The JIRA ticket has the _Patch Available_ state.
   - [ ] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [ ] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
   - [ ] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov merged pull request #9360: IGNITE-14725 Server node fail when user send unsupported class version

Posted by GitBox <gi...@apache.org>.
nizhikov merged pull request #9360:
URL: https://github.com/apache/ignite/pull/9360


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov merged pull request #9360: IGNITE-14725 Server node fail when user send unsupported class version

Posted by GitBox <gi...@apache.org>.
nizhikov merged pull request #9360:
URL: https://github.com/apache/ignite/pull/9360


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Sega76 commented on a change in pull request #9360: IGNITE-14725 Server node fail when user send unsupported class version

Posted by GitBox <gi...@apache.org>.
Sega76 commented on a change in pull request #9360:
URL: https://github.com/apache/ignite/pull/9360#discussion_r699732226



##########
File path: modules/core/src/test/java/org/apache/ignite/p2p/P2PUnsupportedClassVersionTest.java
##########
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.p2p;
+
+import java.lang.reflect.Method;
+import org.apache.ignite.Ignite;
+import org.apache.ignite.IgniteCache;
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteDeploymentException;
+import org.apache.ignite.IgniteException;
+import org.apache.ignite.cache.CacheEntryProcessor;
+import org.apache.ignite.cache.query.ScanQuery;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.failure.StopNodeFailureHandler;
+import org.apache.ignite.internal.managers.communication.GridIoMessage;
+import org.apache.ignite.internal.managers.deployment.GridDeploymentResponse;
+import org.apache.ignite.internal.util.GridByteArrayList;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.lang.IgniteBiPredicate;
+import org.apache.ignite.lang.IgniteCallable;
+import org.apache.ignite.lang.IgniteInClosure;
+import org.apache.ignite.plugin.extensions.communication.Message;
+import org.apache.ignite.spi.IgniteSpiException;
+import org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi;
+import org.apache.ignite.testframework.ListeningTestLogger;
+import org.apache.ignite.testframework.LogListener;
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Test;
+
+import static org.apache.ignite.p2p.P2PScanQueryUndeployTest.PREDICATE_CLASSNAME;
+import static org.apache.ignite.p2p.SharedDeploymentTest.RUN_LAMBDA;
+import static org.apache.ignite.testframework.GridTestUtils.assertThrowsWithCause;
+
+/** Tests user error (not server node failure) in case compute task compiled in unsupported bytecode version. */
+public class P2PUnsupportedClassVersionTest extends GridCommonAbstractTest {
+    /** */
+    public static final String ENTRY_PROC_CLS_NAME = "org.apache.ignite.tests.p2p.CacheDeploymentBinaryEntryProcessor";
+
+    /** */
+    private static ListeningTestLogger lsnrLog;
+
+    /** */
+    private static Ignite srv;
+
+    /** */
+    private static Ignite cli;
+
+    /** {@inheritDoc} */
+    @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
+        return super.getConfiguration(igniteInstanceName)
+            .setPeerClassLoadingEnabled(true)
+            .setCommunicationSpi(new SendComputeWithHigherClassVersionSpi())
+            .setFailureHandler(new StopNodeFailureHandler())
+            .setGridLogger(lsnrLog);
+    }
+
+    /** {@inheritDoc} */
+    @Override protected void beforeTestsStarted() throws Exception {
+        super.beforeTestsStarted();
+
+        lsnrLog = new ListeningTestLogger(false, log);
+
+        srv = startGrid("server");
+        cli = startClientGrid("client");
+    }
+
+    /** */
+    @Test
+    public void testEntryProcessor() throws Exception {
+        IgniteCache<String, String> cache = cli.getOrCreateCache("my-cache");
+
+        cache.put("1", "1");
+
+        LogListener errMsgLsnr = errorMessageListener(ENTRY_PROC_CLS_NAME);
+
+        CacheEntryProcessor<String, String, Boolean> proc = (CacheEntryProcessor<String, String, Boolean>)
+            getExternalClassLoader().loadClass(ENTRY_PROC_CLS_NAME).newInstance();
+
+        Throwable err = assertThrowsWithCause(() -> cache.invoke("1", proc), IgniteCheckedException.class);
+
+        err.printStackTrace();
+

Review comment:
       let's add assertTrue(X.hasCause(err, UnsupportedClassVersionError.class));




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Sega76 commented on a change in pull request #9360: IGNITE-14725 Server node fail when user send unsupported class version

Posted by GitBox <gi...@apache.org>.
Sega76 commented on a change in pull request #9360:
URL: https://github.com/apache/ignite/pull/9360#discussion_r699732226



##########
File path: modules/core/src/test/java/org/apache/ignite/p2p/P2PUnsupportedClassVersionTest.java
##########
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.p2p;
+
+import java.lang.reflect.Method;
+import org.apache.ignite.Ignite;
+import org.apache.ignite.IgniteCache;
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteDeploymentException;
+import org.apache.ignite.IgniteException;
+import org.apache.ignite.cache.CacheEntryProcessor;
+import org.apache.ignite.cache.query.ScanQuery;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.failure.StopNodeFailureHandler;
+import org.apache.ignite.internal.managers.communication.GridIoMessage;
+import org.apache.ignite.internal.managers.deployment.GridDeploymentResponse;
+import org.apache.ignite.internal.util.GridByteArrayList;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.lang.IgniteBiPredicate;
+import org.apache.ignite.lang.IgniteCallable;
+import org.apache.ignite.lang.IgniteInClosure;
+import org.apache.ignite.plugin.extensions.communication.Message;
+import org.apache.ignite.spi.IgniteSpiException;
+import org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi;
+import org.apache.ignite.testframework.ListeningTestLogger;
+import org.apache.ignite.testframework.LogListener;
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Test;
+
+import static org.apache.ignite.p2p.P2PScanQueryUndeployTest.PREDICATE_CLASSNAME;
+import static org.apache.ignite.p2p.SharedDeploymentTest.RUN_LAMBDA;
+import static org.apache.ignite.testframework.GridTestUtils.assertThrowsWithCause;
+
+/** Tests user error (not server node failure) in case compute task compiled in unsupported bytecode version. */
+public class P2PUnsupportedClassVersionTest extends GridCommonAbstractTest {
+    /** */
+    public static final String ENTRY_PROC_CLS_NAME = "org.apache.ignite.tests.p2p.CacheDeploymentBinaryEntryProcessor";
+
+    /** */
+    private static ListeningTestLogger lsnrLog;
+
+    /** */
+    private static Ignite srv;
+
+    /** */
+    private static Ignite cli;
+
+    /** {@inheritDoc} */
+    @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
+        return super.getConfiguration(igniteInstanceName)
+            .setPeerClassLoadingEnabled(true)
+            .setCommunicationSpi(new SendComputeWithHigherClassVersionSpi())
+            .setFailureHandler(new StopNodeFailureHandler())
+            .setGridLogger(lsnrLog);
+    }
+
+    /** {@inheritDoc} */
+    @Override protected void beforeTestsStarted() throws Exception {
+        super.beforeTestsStarted();
+
+        lsnrLog = new ListeningTestLogger(false, log);
+
+        srv = startGrid("server");
+        cli = startClientGrid("client");
+    }
+
+    /** */
+    @Test
+    public void testEntryProcessor() throws Exception {
+        IgniteCache<String, String> cache = cli.getOrCreateCache("my-cache");
+
+        cache.put("1", "1");
+
+        LogListener errMsgLsnr = errorMessageListener(ENTRY_PROC_CLS_NAME);
+
+        CacheEntryProcessor<String, String, Boolean> proc = (CacheEntryProcessor<String, String, Boolean>)
+            getExternalClassLoader().loadClass(ENTRY_PROC_CLS_NAME).newInstance();
+
+        Throwable err = assertThrowsWithCause(() -> cache.invoke("1", proc), IgniteCheckedException.class);
+
+        err.printStackTrace();
+

Review comment:
       let's add assertTrue(X.hasCause(err, UnsupportedClassVersionError.class));




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org