You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/10/08 13:33:28 UTC
[I] [TASK][MEDIUM] Refactor ConfigEntry to replace serverOnly with engineRequired [kyuubi]
pan3793 opened a new issue, #5378:
URL: https://github.com/apache/kyuubi/issues/5378
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before creating
- [X] I have searched in the [task list](https://github.com/orgs/apache/projects/296) and found no similar tasks.
### Mentor
- [X] I have sufficient knowledge and experience of this task, and I volunteer to be the mentor of this task to guide contributors to complete the task.
### Skill requirements
- Basic knowledge on Scala Programing Language
- High Level knowledge of Kyuubi architecture
- Familiar with Kyuubi and each engine's configuration
### Background and Goals
Kyuubi is mainly composed of two components: Server and Engine. Some configurations take effect on both Server and Engine, but some only take effect on Server or specific Engine.
The Server picks up configurations from `kyuubi-defaults.conf` and passes them to the command line during the launching engine process, including some sensitive data. To overcome it, we introduce a `serverOnly` flag on each configuration's definition.
### Implementation steps
Replace the `serverOnly` flag with `requiredByEngines(...)` and `requiredByAllEngines`, so that we can only pass the required configurations to each engine.
Note: we should always bypass the unknown properties to the engine in case some user custom properties do not take effect.
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [I] [TASK][MEDIUM] Refactor ConfigEntry to replace serverOnly with engineRequired [kyuubi]
Posted by "biangjuang (via GitHub)" <gi...@apache.org>.
biangjuang commented on issue #5378:
URL: https://github.com/apache/kyuubi/issues/5378#issuecomment-1760975140
I want to try this, I hope to complete it within a week(Before Oct 22nd)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [I] [TASK][MEDIUM] Refactor ConfigEntry to replace serverOnly with engineRequired [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on issue #5378:
URL: https://github.com/apache/kyuubi/issues/5378#issuecomment-1761056266
@biangjuang thanks, assigned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org