You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/03/25 01:10:01 UTC
[kudu-CR] WIP: tablet: skip over gaps in rowsets using key index instead of bloom
Hello David Ribeiro Alves,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6484
to review the following change.
Change subject: WIP: tablet: skip over gaps in rowsets using key index instead of bloom
......................................................................
WIP: tablet: skip over gaps in rowsets using key index instead of bloom
This leverages the rowset-wise application of write ops to look for
"gaps" in the rowset where multiple insertions fall. For example, a
rowset might include keys like '1996-01-01...' and then skip to keys
like '1996-02-01...'. If a batch of writes comes with all rows falling
between those two keys, this patch allows us to more effiicently notice
that all of the writes are non-duplicate without doing per-op bloom
checks.
This is substantially faster for many workloads.
TODO: doc benchmarks, much cleanup
Change-Id: I1b2277c7cc9e10f566ff53b9fe22ca17dc27c688
---
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/diskrowset.h
M src/kudu/tablet/rowset.h
M src/kudu/tablet/tablet.cc
6 files changed, 86 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/6484/1
--
To view, visit http://gerrit.cloudera.org:8080/6484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b2277c7cc9e10f566ff53b9fe22ca17dc27c688
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] WIP: tablet: skip over gaps in rowsets using key index instead of bloom
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6484
to look at the new patch set (#2).
Change subject: WIP: tablet: skip over gaps in rowsets using key index instead of bloom
......................................................................
WIP: tablet: skip over gaps in rowsets using key index instead of bloom
This leverages the rowset-wise application of write ops to look for
"gaps" in the rowset where multiple insertions fall. For example, a
rowset might include keys like '1996-01-01...' and then skip to keys
like '1996-02-01...'. If a batch of writes comes with all rows falling
between those two keys, this patch allows us to more effiicently notice
that all of the writes are non-duplicate without doing per-op bloom
checks.
This is substantially faster for many workloads.
TODO: doc benchmarks, much cleanup
Change-Id: I1b2277c7cc9e10f566ff53b9fe22ca17dc27c688
---
M src/kudu/cfile/cfile_reader.h
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/diskrowset.h
M src/kudu/tablet/rowset.h
M src/kudu/tablet/tablet.cc
7 files changed, 103 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/6484/2
--
To view, visit http://gerrit.cloudera.org:8080/6484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1b2277c7cc9e10f566ff53b9fe22ca17dc27c688
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] WIP: tablet: skip over gaps in rowsets using key index instead of bloom
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: WIP: tablet: skip over gaps in rowsets using key index instead of bloom
......................................................................
Patch Set 2:
review?
--
To view, visit http://gerrit.cloudera.org:8080/6484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b2277c7cc9e10f566ff53b9fe22ca17dc27c688
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No