You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2018/12/08 12:27:00 UTC
[incubator-skywalking] branch new-doc created (now ec636d9)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch new-doc
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git.
at ec636d9 Add a document link in plugin contribution.
This branch includes the following new commits:
new ec636d9 Add a document link in plugin contribution.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[incubator-skywalking] 01/01: Add a document link in plugin
contribution.
Posted by wu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch new-doc
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git
commit ec636d93cf4d8fbcfe62c6dd93cad8250b7b1ec8
Author: Wu Sheng <wu...@foxmail.com>
AuthorDate: Sat Dec 8 20:26:49 2018 +0800
Add a document link in plugin contribution.
---
docs/en/guides/Java-Plugin-Development-Guide.md | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/docs/en/guides/Java-Plugin-Development-Guide.md b/docs/en/guides/Java-Plugin-Development-Guide.md
index 7de1317..5de9406 100644
--- a/docs/en/guides/Java-Plugin-Development-Guide.md
+++ b/docs/en/guides/Java-Plugin-Development-Guide.md
@@ -281,9 +281,12 @@ We are welcome everyone to contribute plugins.
Please follow there steps:
1. Submit an issue about which plugins are you going to contribute, including supported version.
-1. Create sub modules under `apm-sniffer/apm-sdk-plugin`, and the name should include supported library name and versions
+1. Create sub modules under `apm-sniffer/apm-sdk-plugin` or `apm-sniffer/optional-plugins`, and the name should include supported library name and versions
1. Follow this guide to develop. Make sure comments and test cases are provided.
1. Develop and test.
-1. Send the pull request and ask for review, and provide the automatic test cases by following PMC members guides.
+1. Send the pull request and ask for review.
+1. Provide the automatic test cases.
+All test cases are hosted in [SkywalkingTest/skywalking-agent-testcases repository](https://github.com/SkywalkingTest/skywalking-agent-testcases).
+About how to write a test case, follow the [How to write](https://github.com/SkywalkingTest/skywalking-agent-testcases/blob/master/docs/how-to-write-a-plugin-testcase.md) document.
1. The plugin committers approves your plugins after automatic test cases provided and the tests passed in our CI.
1. The plugin accepted by SkyWalking.