You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/10/19 18:20:00 UTC
[GitHub] [cordova-android] raphinesse opened a new pull request #1101: refactor: unify target resolution & installation code for devices & emulators
raphinesse opened a new pull request #1101:
URL: https://github.com/apache/cordova-android/pull/1101
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Simplifies and deduplicates code that is used to detect run targets and install an app to a target.
This refactoring was triggered by my ongoing work to stop copying `cordova/lib` to the platform folder.
Marked _draft_ because this currently just drops the code mentioned in #1098 . I would appreciate reviews anyways.
### Description
<!-- Describe your changes in detail -->
- removed filtering option from `Adb.devices` (now we can get a list of emulators and devices w/ one spawn)
- factored the mostly identical methods `{device, emulator}.{list,list_started,resolveTarget,install}` out to the new module `target`. Those methods are virtually only used by the `run` module.
- the part of the target resolution that was implemented in the `run` module has also been moved to the `target` module.
### Testing
<!-- Please describe in detail how you tested your changes. -->
Updated unit tests pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1101: refactor: unify target resolution for devices & emulators
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1101:
URL: https://github.com/apache/cordova-android/pull/1101#issuecomment-712358586
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=h1) Report
> Merging [#1101](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=desc) (0e8da4f) into [master](https://codecov.io/gh/apache/cordova-android/commit/b2453375019c568980d2f0d8dc7cb6e18dedd2eb?el=desc) (b245337) will **decrease** coverage by `0.59%`.
> The diff coverage is `94.59%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1101 +/- ##
==========================================
- Coverage 71.19% 70.59% -0.60%
==========================================
Files 21 20 -1
Lines 1739 1714 -25
==========================================
- Hits 1238 1210 -28
- Misses 501 504 +3
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.77% <ø> (-0.08%)` | :arrow_down: |
| [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `94.44% <92.30%> (-2.33%)` | :arrow_down: |
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `97.56% <100.00%> (-2.44%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=footer). Last update [b245337...0e8da4f](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1101: refactor: unify target resolution & installation code for devices & emulators
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1101:
URL: https://github.com/apache/cordova-android/pull/1101#issuecomment-712358586
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=h1) Report
> Merging [#1101](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=desc) (d0d5141) into [master](https://codecov.io/gh/apache/cordova-android/commit/671e1fd1c60b58cd5061f5037cdfb2169ac21d60?el=desc) (671e1fd) will **decrease** coverage by `1.05%`.
> The diff coverage is `95.00%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1101 +/- ##
==========================================
- Coverage 70.02% 68.97% -1.06%
==========================================
Files 20 20
Lines 1775 1731 -44
==========================================
- Hits 1243 1194 -49
- Misses 532 537 +5
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `97.56% <92.85%> (-2.44%)` | :arrow_down: |
| [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `94.44% <94.44%> (ø)` | |
| [bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=) | `100.00% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.77% <100.00%> (-0.25%)` | :arrow_down: |
| [bin/templates/cordova/lib/utils.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi91dGlscy5qcw==) | `100.00% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.49% <0.00%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=footer). Last update [671e1fd...d0d5141](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io commented on pull request #1101: refactor: unify target resolution & installation code for devices & emulators
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1101:
URL: https://github.com/apache/cordova-android/pull/1101#issuecomment-712358586
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=h1) Report
> Merging [#1101](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/335b0f2575bdcb432583132f17b5f141c64e7c0b?el=desc) will **decrease** coverage by `1.34%`.
> The diff coverage is `95.23%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1101 +/- ##
==========================================
- Coverage 69.71% 68.36% -1.35%
==========================================
Files 20 20
Lines 1806 1745 -61
==========================================
- Hits 1259 1193 -66
- Misses 547 552 +5
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `97.56% <92.85%> (-2.44%)` | :arrow_down: |
| [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `94.54% <94.54%> (ø)` | |
| [bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=) | `100.00% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.77% <100.00%> (+0.64%)` | :arrow_up: |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `57.54% <0.00%> (-1.42%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=footer). Last update [335b0f2...64cd882](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1101: refactor: unify target resolution & installation code for devices & emulators
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1101:
URL: https://github.com/apache/cordova-android/pull/1101#issuecomment-712358586
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=h1) Report
> Merging [#1101](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=desc) (3cce4c9) into [master](https://codecov.io/gh/apache/cordova-android/commit/aa679ea1d6ddd63ce4a8d64925637e75482d5374?el=desc) (aa679ea) will **decrease** coverage by `1.16%`.
> The diff coverage is `94.28%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1101 +/- ##
==========================================
- Coverage 71.41% 70.24% -1.17%
==========================================
Files 20 20
Lines 1770 1724 -46
==========================================
- Hits 1264 1211 -53
- Misses 506 513 +7
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.77% <ø> (-0.26%)` | :arrow_down: |
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `97.56% <92.85%> (-2.44%)` | :arrow_down: |
| [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `94.44% <94.44%> (ø)` | |
| [bin/templates/cordova/lib/utils.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi91dGlscy5qcw==) | `100.00% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `68.78% <0.00%> (-1.47%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=footer). Last update [aa679ea...3cce4c9](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1101: refactor: unify target resolution for devices & emulators
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1101:
URL: https://github.com/apache/cordova-android/pull/1101#issuecomment-712358586
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=h1) Report
> Merging [#1101](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=desc) (0e8da4f) into [master](https://codecov.io/gh/apache/cordova-android/commit/b2453375019c568980d2f0d8dc7cb6e18dedd2eb?el=desc) (b245337) will **decrease** coverage by `0.65%`.
> The diff coverage is `94.59%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1101 +/- ##
==========================================
- Coverage 71.19% 70.53% -0.66%
==========================================
Files 21 20 -1
Lines 1739 1714 -25
==========================================
- Hits 1238 1209 -29
- Misses 501 505 +4
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.77% <ø> (-0.08%)` | :arrow_down: |
| [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `94.44% <92.30%> (-2.33%)` | :arrow_down: |
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `97.56% <100.00%> (-2.44%)` | :arrow_down: |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `69.75% <0.00%> (-0.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=footer). Last update [b245337...0e8da4f](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1101: refactor: unify target resolution & installation code for devices & emulators
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1101:
URL: https://github.com/apache/cordova-android/pull/1101#issuecomment-712358586
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=h1) Report
> Merging [#1101](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=desc) (2435eb5) into [master](https://codecov.io/gh/apache/cordova-android/commit/aa679ea1d6ddd63ce4a8d64925637e75482d5374?el=desc) (aa679ea) will **decrease** coverage by `0.99%`.
> The diff coverage is `94.28%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1101 +/- ##
==========================================
- Coverage 71.41% 70.41% -1.00%
==========================================
Files 20 20
Lines 1770 1724 -46
==========================================
- Hits 1264 1214 -50
- Misses 506 510 +4
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.77% <ø> (-0.26%)` | :arrow_down: |
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `97.56% <92.85%> (-2.44%)` | :arrow_down: |
| [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `94.44% <94.44%> (ø)` | |
| [bin/templates/cordova/lib/utils.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi91dGlscy5qcw==) | `100.00% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=footer). Last update [aa679ea...3cce4c9](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on pull request #1101: refactor: unify target resolution for devices & emulators
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #1101:
URL: https://github.com/apache/cordova-android/pull/1101#issuecomment-816377166
@raphinesse From a quick run test, I see a subtle difference.
I haven't covered cases but here is one example:
When running the command `cordova run android --target`:
The Main Branch Ending Printout:
```
Using Android SDK: /Users/cordova/Library/Android/sdk
No target specified and no devices found, deploying to emulator
Failed to execute shell command "getprop,sys.boot_completed" on device: Error: Command failed with exit code 1: adb -s shell getprop sys.boot_completed
adb: device 'undefined' not found
```
This PR's Ending Printout:
```
Using Android SDK: /Users/cordova/Library/Android/sdk
Deploying to emulator emulator-5554
Using apk: /Users/cordova/.test/someRandomProject2/platforms/android/app/build/outputs/apk/debug/app-debug.apk
Package name: com.erisu.someRandomProject2
INSTALL SUCCESS
LAUNCH SUCCESS
```
As seen, the warning message `No target specified and no devices found, deploying to emulator` is missing from this PR.
I suspect a refactor shouldn't lose warning messages. I think improvements in visuals, such as spacing, on the other hand, are acceptable.
A bonus from your PR is that it launches the emulator when the target is not provided. The main branch fails to launch even though the warning said it would launch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1101: refactor: unify target resolution & installation code for devices & emulators
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1101:
URL: https://github.com/apache/cordova-android/pull/1101#issuecomment-712358586
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=h1) Report
> Merging [#1101](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=desc) (3cce4c9) into [master](https://codecov.io/gh/apache/cordova-android/commit/aa679ea1d6ddd63ce4a8d64925637e75482d5374?el=desc) (aa679ea) will **decrease** coverage by `0.99%`.
> The diff coverage is `94.28%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1101 +/- ##
==========================================
- Coverage 71.41% 70.41% -1.00%
==========================================
Files 20 20
Lines 1770 1724 -46
==========================================
- Hits 1264 1214 -50
- Misses 506 510 +4
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.77% <ø> (-0.26%)` | :arrow_down: |
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `97.56% <92.85%> (-2.44%)` | :arrow_down: |
| [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `94.44% <94.44%> (ø)` | |
| [bin/templates/cordova/lib/utils.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi91dGlscy5qcw==) | `100.00% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=footer). Last update [aa679ea...3cce4c9](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1101: refactor: unify target resolution & installation code for devices & emulators
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1101:
URL: https://github.com/apache/cordova-android/pull/1101#issuecomment-712358586
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=h1) Report
> Merging [#1101](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/335b0f2575bdcb432583132f17b5f141c64e7c0b?el=desc) will **decrease** coverage by `1.17%`.
> The diff coverage is `95.23%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1101 +/- ##
==========================================
- Coverage 69.71% 68.53% -1.18%
==========================================
Files 20 20
Lines 1806 1745 -61
==========================================
- Hits 1259 1196 -63
- Misses 547 549 +2
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `97.56% <92.85%> (-2.44%)` | :arrow_down: |
| [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `94.54% <94.54%> (ø)` | |
| [bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=) | `100.00% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.77% <100.00%> (+0.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=footer). Last update [335b0f2...64cd882](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1101: refactor: unify target resolution for devices & emulators
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1101:
URL: https://github.com/apache/cordova-android/pull/1101#issuecomment-712358586
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=h1) Report
> Merging [#1101](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=desc) (5a816d0) into [master](https://codecov.io/gh/apache/cordova-android/commit/b2453375019c568980d2f0d8dc7cb6e18dedd2eb?el=desc) (b245337) will **decrease** coverage by `0.59%`.
> The diff coverage is `94.59%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1101 +/- ##
==========================================
- Coverage 71.19% 70.59% -0.60%
==========================================
Files 21 20 -1
Lines 1739 1714 -25
==========================================
- Hits 1238 1210 -28
- Misses 501 504 +3
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.77% <ø> (-0.08%)` | :arrow_down: |
| [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `94.44% <92.30%> (-2.33%)` | :arrow_down: |
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `97.56% <100.00%> (-2.44%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=footer). Last update [b245337...5a816d0](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1101: refactor: unify target resolution for devices & emulators
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1101:
URL: https://github.com/apache/cordova-android/pull/1101#issuecomment-712358586
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=h1) Report
> Merging [#1101](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=desc) (5a816d0) into [master](https://codecov.io/gh/apache/cordova-android/commit/b2453375019c568980d2f0d8dc7cb6e18dedd2eb?el=desc) (b245337) will **decrease** coverage by `0.59%`.
> The diff coverage is `94.59%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1101 +/- ##
==========================================
- Coverage 71.13% 70.53% -0.60%
==========================================
Files 21 20 -1
Lines 1739 1714 -25
==========================================
- Hits 1237 1209 -28
- Misses 502 505 +3
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.77% <ø> (-0.08%)` | :arrow_down: |
| [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `94.44% <92.30%> (-2.33%)` | :arrow_down: |
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `97.56% <100.00%> (-2.44%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=footer). Last update [b245337...5a816d0](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1101: refactor: unify target resolution & installation code for devices & emulators
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1101:
URL: https://github.com/apache/cordova-android/pull/1101#issuecomment-712358586
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=h1) Report
> Merging [#1101](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/335b0f2575bdcb432583132f17b5f141c64e7c0b?el=desc) will **decrease** coverage by `1.21%`.
> The diff coverage is `95.29%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1101 +/- ##
==========================================
- Coverage 69.71% 68.49% -1.22%
==========================================
Files 20 20
Lines 1806 1746 -60
==========================================
- Hits 1259 1196 -63
- Misses 547 550 +3
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `97.56% <92.85%> (-2.44%)` | :arrow_down: |
| [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `94.44% <94.44%> (ø)` | |
| [bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=) | `100.00% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.77% <100.00%> (+0.64%)` | :arrow_up: |
| [bin/templates/cordova/lib/utils.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi91dGlscy5qcw==) | `100.00% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.49% <0.00%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=footer). Last update [335b0f2...b7bd688](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1101: refactor: unify target resolution & installation code for devices & emulators
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1101:
URL: https://github.com/apache/cordova-android/pull/1101#issuecomment-712358586
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=h1) Report
> Merging [#1101](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=desc) (d0d5141) into [master](https://codecov.io/gh/apache/cordova-android/commit/671e1fd1c60b58cd5061f5037cdfb2169ac21d60?el=desc) (671e1fd) will **decrease** coverage by `0.99%`.
> The diff coverage is `95.00%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1101 +/- ##
==========================================
- Coverage 70.02% 69.03% -1.00%
==========================================
Files 20 20
Lines 1775 1731 -44
==========================================
- Hits 1243 1195 -48
- Misses 532 536 +4
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `97.56% <92.85%> (-2.44%)` | :arrow_down: |
| [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `94.44% <94.44%> (ø)` | |
| [bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=) | `100.00% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.77% <100.00%> (-0.25%)` | :arrow_down: |
| [bin/templates/cordova/lib/utils.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi91dGlscy5qcw==) | `100.00% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=footer). Last update [671e1fd...d0d5141](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu merged pull request #1101: refactor: unify target resolution for devices & emulators
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #1101:
URL: https://github.com/apache/cordova-android/pull/1101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1101: refactor: unify target resolution & installation code for devices & emulators
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1101:
URL: https://github.com/apache/cordova-android/pull/1101#issuecomment-712358586
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=h1) Report
> Merging [#1101](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/335b0f2575bdcb432583132f17b5f141c64e7c0b?el=desc) will **decrease** coverage by `1.23%`.
> The diff coverage is `95.23%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1101 +/- ##
==========================================
- Coverage 69.71% 68.48% -1.24%
==========================================
Files 20 20
Lines 1806 1745 -61
==========================================
- Hits 1259 1195 -64
- Misses 547 550 +3
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `97.56% <92.85%> (-2.44%)` | :arrow_down: |
| [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `94.54% <94.54%> (ø)` | |
| [bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=) | `100.00% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.77% <100.00%> (+0.64%)` | :arrow_up: |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1101/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.49% <0.00%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=footer). Last update [335b0f2...64cd882](https://codecov.io/gh/apache/cordova-android/pull/1101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] raphinesse commented on pull request #1101: refactor: unify target resolution & installation code for devices & emulators
Posted by GitBox <gi...@apache.org>.
raphinesse commented on pull request #1101:
URL: https://github.com/apache/cordova-android/pull/1101#issuecomment-728943037
Converted to draft until the PRs that this one depends on are merged (commits marked as `[DEP]`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu edited a comment on pull request #1101: refactor: unify target resolution for devices & emulators
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #1101:
URL: https://github.com/apache/cordova-android/pull/1101#issuecomment-816377166
@raphinesse From a quick run test, I see a subtle difference.
I haven't covered all cases but here is one example:
When running the command `cordova run android --target`:
The Main Branch Ending Printout:
```
Using Android SDK: /Users/cordova/Library/Android/sdk
No target specified and no devices found, deploying to emulator
Failed to execute shell command "getprop,sys.boot_completed" on device: Error: Command failed with exit code 1: adb -s shell getprop sys.boot_completed
adb: device 'undefined' not found
```
This PR's Ending Printout:
```
Using Android SDK: /Users/cordova/Library/Android/sdk
Deploying to emulator emulator-5554
Using apk: /Users/cordova/.test/someRandomProject2/platforms/android/app/build/outputs/apk/debug/app-debug.apk
Package name: com.erisu.someRandomProject2
INSTALL SUCCESS
LAUNCH SUCCESS
```
As seen, the warning message `No target specified and no devices found, deploying to emulator` is missing from this PR.
I suspect a refactor shouldn't lose warning messages. I think improvements in visuals, such as spacing, on the other hand, are acceptable.
A bonus from your PR is that it launches the emulator when the target is not provided. The main branch fails to launch even though the warning said it would launch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org