[GitHub] [spark] srowen commented on a change in pull request #25470: [SPARK-28751][Core][WIP] Improve java serializer deserialization performance

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #25470: [SPARK-28751][Core][WIP] Improve java serializer deserialization performance
URL: https://github.com/apache/spark/pull/25470#discussion_r319106688
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/serializer/JavaSerializerSuite.scala
 ##########
 @@ -18,26 +18,114 @@
 package org.apache.spark.serializer
 
 import org.apache.spark.{SparkConf, SparkFunSuite}
+import org.apache.spark.internal.config.JAVA_SERIALIZER_CACHE_RESOLVED_CLASSES
 
 class JavaSerializerSuite extends SparkFunSuite {
-  test("JavaSerializer instances are serializable") {
-    val serializer = new JavaSerializer(new SparkConf())
+  test("JavaSerializer(without resolve class cache) instances are serializable") {
 
 Review comment:
   Nit: space before parens

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org