You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/11 16:17:37 UTC

[GitHub] [superset] rusackas commented on pull request #19873: feat(css): adds `chartId`-based class to dashboard chart holder

rusackas commented on PR #19873:
URL: https://github.com/apache/superset/pull/19873#issuecomment-1123982232

   > Should we add a comment in the code with the reasoning to prevent anyone in the future to delete this class because it's not being used?
   
   Excellent suggestion! Thank you for that. I added one, so if it seems sufficiently explanatory, I'd love a (re)review :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org