You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/20 23:12:22 UTC

[GitHub] [airflow] artem-bondar opened a new pull request #18396: Fixing typo in PythonOperator example dag

artem-bondar opened a new pull request #18396:
URL: https://github.com/apache/airflow/pull/18396


   Fixed an obvious typo in PythonOperator example dag, nothing to say more on this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18396: Fixing typo in PythonOperator example dag

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #18396:
URL: https://github.com/apache/airflow/pull/18396#issuecomment-923422491


   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโ€™s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better ๐Ÿš€.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] SamWheating edited a comment on pull request #18396: Fixing typo in PythonOperator example dag

Posted by GitBox <gi...@apache.org>.
SamWheating edited a comment on pull request #18396:
URL: https://github.com/apache/airflow/pull/18396#issuecomment-923431560


   This actually looks like an intentional use of the [`pprint`](https://docs.python.org/3/library/pprint.html) python library, which is used for pretty-printing python objects. 
   
   
   The `pprint` function is imported earlier in this file:
   https://github.com/apache/airflow/blob/463ed82255403cd5663160140c44987d61e893a3/airflow/example_dags/example_python_operator.py#L22
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] SamWheating commented on pull request #18396: Fixing typo in PythonOperator example dag

Posted by GitBox <gi...@apache.org>.
SamWheating commented on pull request #18396:
URL: https://github.com/apache/airflow/pull/18396#issuecomment-923431560


   This actually looks like an intentional use of the [`pprint`](https://docs.python.org/3/library/pprint.html) python library, which is used for pretty-printing python objects. 
   
   https://github.com/apache/airflow/blob/463ed82255403cd5663160140c44987d61e893a3/airflow/example_dags/example_python_operator.py#L22
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil closed pull request #18396: Fixing typo in PythonOperator example dag

Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #18396:
URL: https://github.com/apache/airflow/pull/18396


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on a change in pull request #18396: Fixing typo in PythonOperator example dag

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #18396:
URL: https://github.com/apache/airflow/pull/18396#discussion_r712588884



##########
File path: airflow/example_dags/example_python_operator.py
##########
@@ -34,7 +34,7 @@
     # [START howto_operator_python]
     def print_context(ds, **kwargs):
         """Print the Airflow context and ds variable from the context."""
-        pprint(kwargs)
+        print(kwargs)

Review comment:
       `pprint` is correct, check the import line on L22
   
   https://github.com/apache/airflow/blob/463ed82255403cd5663160140c44987d61e893a3/airflow/example_dags/example_python_operator.py#L22




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] artem-bondar commented on a change in pull request #18396: Fixing typo in PythonOperator example dag

Posted by GitBox <gi...@apache.org>.
artem-bondar commented on a change in pull request #18396:
URL: https://github.com/apache/airflow/pull/18396#discussion_r712598811



##########
File path: airflow/example_dags/example_python_operator.py
##########
@@ -34,7 +34,7 @@
     # [START howto_operator_python]
     def print_context(ds, **kwargs):
         """Print the Airflow context and ds variable from the context."""
-        pprint(kwargs)
+        print(kwargs)

Review comment:
       oh, sorry for bothering, shame on me, too inattentive late at night :/




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org