[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #636: Support for MQTT-C

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #636:
URL: https://github.com/apache/incubator-nuttx-apps/pull/636#discussion_r603044377



##########
File path: mqtt/mqttc/Kconfig
##########
@@ -0,0 +1,18 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config MQTT_MQTTC

Review comment:
       change MQTT_MQTTC to MQTTC?

##########
File path: mqtt/mqttc/Kconfig
##########
@@ -0,0 +1,18 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config MQTT_MQTTC

Review comment:
       should we add NETUTILS_ prefix?

##########
File path: mqtt/mqttc/Make.defs
##########
@@ -0,0 +1,32 @@
+############################################################################
+# apps/mqtt/mqttc/Make.defs
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.  The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+ifneq ($(CONFIG_MQTT_MQTTC),)
+CONFIGURED_APPS += $(APPDIR)/mqtt/mqttc
+
+CFLAGS   += -D__unix__
+CXXFLAGS += -D__unix__

Review comment:
       ```__unix__``` is only used in implementation, it's better to move CLFAGS/CXXFLAGS into Makefile

##########
File path: mqtt/mqttc/Make.defs
##########
@@ -0,0 +1,32 @@
+############################################################################
+# apps/mqtt/mqttc/Make.defs

Review comment:
       change path to netutils/mqttc?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org