[GitHub] [lucene-solr] dweiss commented on a change in pull request #2347: LUCENE-9760: Hunspell: print total memory usage in TestAllDictionarie…

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #2347:
URL: https://github.com/apache/lucene-solr/pull/2347#discussion_r574309396



##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestAllDictionaries.java
##########
@@ -181,11 +188,16 @@ public void testDictionariesLoadSuccessfully() throws Exception {
       }
     } finally {
       executor.shutdown();
-      executor.awaitTermination(1, TimeUnit.MINUTES);
+      assertTrue(executor.awaitTermination(1, TimeUnit.MINUTES));

Review comment:
       The test runner would also capture and report any escaped threads, even if this falls through.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org