You are viewing a plain text version of this content. The canonical link for it is here.
Posted to droids-dev@incubator.apache.org by "Florent ANDRE (JIRA)" <ji...@apache.org> on 2010/08/02 00:13:17 UTC
[jira] Created: (DROIDS-96) [Droids crawler] Maven : add the
droids-crawler module in the parent pom
[Droids crawler] Maven : add the droids-crawler module in the parent pom
------------------------------------------------------------------------
Key: DROIDS-96
URL: https://issues.apache.org/jira/browse/DROIDS-96
Project: Droids
Issue Type: Bug
Reporter: Florent ANDRE
Attachments: patch-parent-pom-add-crawler-r981279
I don't know if there is a special reason for don't list this module into the parent pom, but as crawler is an important part of droids, why not put it in the parent ?
This patch do this ! :)
Apply droids-94 and 95 before.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DROIDS-96) [Droids crawler] Maven : add the
droids-crawler module in the parent pom
Posted by "Florent ANDRE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Florent ANDRE resolved DROIDS-96.
---------------------------------
Resolution: Fixed
> [Droids crawler] Maven : add the droids-crawler module in the parent pom
> ------------------------------------------------------------------------
>
> Key: DROIDS-96
> URL: https://issues.apache.org/jira/browse/DROIDS-96
> Project: Droids
> Issue Type: Bug
> Reporter: Florent ANDRE
> Attachments: patch-parent-pom-add-crawler-r981279
>
>
> I don't know if there is a special reason for don't list this module into the parent pom, but as crawler is an important part of droids, why not put it in the parent ?
> This patch do this ! :)
> Apply droids-94 and 95 before.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DROIDS-96) [Droids crawler] Maven : add the
droids-crawler module in the parent pom
Posted by "Florent ANDRE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894499#action_12894499 ]
Florent ANDRE commented on DROIDS-96:
-------------------------------------
Ok thanks,
This may explain my confusion when I build my first droid some month ago...
As I would like to now restart on a more clean and more recent droid implementation, I will try to restart from droids-core.
IMO a droids-crawler module in Droids is "sexy" and do some good press for the project... Hope to see a clean droids-crawler in the future ! :)
Mark this issue as solve. I do the same for Droids 94 and 95 ?
Thanks
> [Droids crawler] Maven : add the droids-crawler module in the parent pom
> ------------------------------------------------------------------------
>
> Key: DROIDS-96
> URL: https://issues.apache.org/jira/browse/DROIDS-96
> Project: Droids
> Issue Type: Bug
> Reporter: Florent ANDRE
> Attachments: patch-parent-pom-add-crawler-r981279
>
>
> I don't know if there is a special reason for don't list this module into the parent pom, but as crawler is an important part of droids, why not put it in the parent ?
> This patch do this ! :)
> Apply droids-94 and 95 before.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DROIDS-96) [Droids crawler] Maven : add the
droids-crawler module in the parent pom
Posted by "Florent ANDRE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Florent ANDRE updated DROIDS-96:
--------------------------------
Attachment: patch-parent-pom-add-crawler-r981279
> [Droids crawler] Maven : add the droids-crawler module in the parent pom
> ------------------------------------------------------------------------
>
> Key: DROIDS-96
> URL: https://issues.apache.org/jira/browse/DROIDS-96
> Project: Droids
> Issue Type: Bug
> Reporter: Florent ANDRE
> Attachments: patch-parent-pom-add-crawler-r981279
>
>
> I don't know if there is a special reason for don't list this module into the parent pom, but as crawler is an important part of droids, why not put it in the parent ?
> This patch do this ! :)
> Apply droids-94 and 95 before.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DROIDS-96) [Droids crawler] Maven : add the
droids-crawler module in the parent pom
Posted by "Mingfai Ma (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894469#action_12894469 ]
Mingfai Ma commented on DROIDS-96:
----------------------------------
I think I'm the person who created the crawler module in around a year ago.
there are several issues with the module that it should *not* be added to the parent module (and should be removed from this project)
1. the initial code and concepts are originated from Droids' crawler code, but i made too many changes at that time that I couldn't make the module to use the parent/droids-core module (unless I also make significant change to droids-core ...). so, the module is actually a standalone one, works independent of droids.
2. i believe i'm the only one who has committed code for that module, and the last update is around a year ago. I actually keep developing the crawler but not based on that droids-crawler trunk. In other words, the droids-crawler module in svn is unmaintained now.
for the two reasons above, i think the module in svn should be obsoleted / deleted.
I don't mind to release the latest crawler code i use if anyone may use it, but it still has the old problem that it doesn't use droids-core. I think if it doesn't use droids-core, it can't be called a droids-crawler.
> [Droids crawler] Maven : add the droids-crawler module in the parent pom
> ------------------------------------------------------------------------
>
> Key: DROIDS-96
> URL: https://issues.apache.org/jira/browse/DROIDS-96
> Project: Droids
> Issue Type: Bug
> Reporter: Florent ANDRE
> Attachments: patch-parent-pom-add-crawler-r981279
>
>
> I don't know if there is a special reason for don't list this module into the parent pom, but as crawler is an important part of droids, why not put it in the parent ?
> This patch do this ! :)
> Apply droids-94 and 95 before.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.