You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2008/04/07 00:54:56 UTC
svn commit: r645323 -
/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ntp/NtpV3Impl.java
Author: sebb
Date: Sun Apr 6 15:54:49 2008
New Revision: 645323
URL: http://svn.apache.org/viewvc?rev=645323&view=rev
Log:
NET-195 - fix incorrect double-checked locking
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ntp/NtpV3Impl.java
Modified: commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ntp/NtpV3Impl.java
URL: http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ntp/NtpV3Impl.java?rev=645323&r1=645322&r2=645323&view=diff
==============================================================================
--- commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ntp/NtpV3Impl.java (original)
+++ commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ntp/NtpV3Impl.java Sun Apr 6 15:54:49 2008
@@ -508,15 +508,12 @@
*
* @return a datagram packet.
*/
- public DatagramPacket getDatagramPacket()
+ public synchronized DatagramPacket getDatagramPacket()
{
- if (dp == null)
- synchronized(this) {
- if (dp == null) {
- dp = new DatagramPacket(buf, buf.length);
- dp.setPort(NTP_PORT);
- }
- }
+ if (dp == null) {
+ dp = new DatagramPacket(buf, buf.length);
+ dp.setPort(NTP_PORT);
+ }
return dp;
}